RTPNGExporter - review needed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: RTPNGExporter - review needed

Jan Blizničenko
Hi

Well, that's not the first time I hear that I should try to avoid symbols in interface and calls outside my class, I'm just not yet sure why is that. Might it be refactoring, which would not change names in symbols?

Anyway, there is version without them...
export: method replaced by asPNG, asBMP etc. and without constructing class names

http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st

Jan

Nicolai Hess wrote
2014-11-18 13:51 GMT+01:00 Tudor Girba <[hidden email]>:

> I did not get a chance of going over it. Anyone else?
>
> We need a resolution this week so that we can release next week.
>

which one, the DCTRCanvasExporter?
I didn't test the code, just looked at the source.

It looks good and I like the scaleToMorphLimits

What I don't like is the "construct-class-name-from-image-extension-name":

Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol






>
> Cheers,
> Doru
>
Reply | Threaded
Open this post in threaded view
|

Re: RTPNGExporter - review needed

Nicolai Hess
2014-11-26 12:24 GMT+01:00 Jan B. <[hidden email]>:
Hi

Well, that's not the first time I hear that I should try to avoid symbols in
interface and calls outside my class, I'm just not yet sure why is that.
Might it be refactoring, which would not change names in symbols?

Yes, and a search like "users of" or "references to " ( SystemNavigation default browseAllCallsOnClass:PNGReadWriter )
Can not find code where the class name is constructed with string concatenation.


 

Anyway, there is version without them...
export: method replaced by asPNG, asBMP etc. and without constructing class
names

http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st

Jan


Nicolai Hess wrote
> 2014-11-18 13:51 GMT+01:00 Tudor Girba &lt;

> tudor@

> &gt;:
>
>> I did not get a chance of going over it. Anyone else?
>>
>> We need a resolution this week so that we can release next week.
>>
>
> which one, the DCTRCanvasExporter?
> I didn't test the code, just looked at the source.
>
> It looks good and I like the scaleToMorphLimits
>
> What I don't like is the "construct-class-name-from-image-extension-name":
>
> Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
>
>
>
>
>
>
>>
>> Cheers,
>> Doru
>>





--
View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4792320.html
Sent from the Moose mailing list archive at Nabble.com.
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: RTPNGExporter - review needed

Tudor Girba-2
+1.

Let's leave string concatenation for other languages :)

Doru

On Wed, Nov 26, 2014 at 8:47 PM, Nicolai Hess <[hidden email]> wrote:
2014-11-26 12:24 GMT+01:00 Jan B. <[hidden email]>:
Hi

Well, that's not the first time I hear that I should try to avoid symbols in
interface and calls outside my class, I'm just not yet sure why is that.
Might it be refactoring, which would not change names in symbols?

Yes, and a search like "users of" or "references to " ( SystemNavigation default browseAllCallsOnClass:PNGReadWriter )
Can not find code where the class name is constructed with string concatenation.


 

Anyway, there is version without them...
export: method replaced by asPNG, asBMP etc. and without constructing class
names

http://www.mediafire.com/download/htnazneiizll539/DCTRCanvasExporter02.st

Jan


Nicolai Hess wrote
> 2014-11-18 13:51 GMT+01:00 Tudor Girba &lt;

> tudor@

> &gt;:
>
>> I did not get a chance of going over it. Anyone else?
>>
>> We need a resolution this week so that we can release next week.
>>
>
> which one, the DCTRCanvasExporter?
> I didn't test the code, just looked at the source.
>
> It looks good and I like the scaleToMorphLimits
>
> What I don't like is the "construct-class-name-from-image-extension-name":
>
> Smalltalk at: (imageFormatUC , 'ReadWriter') asSymbol
>
>
>
>
>
>
>>
>> Cheers,
>> Doru
>>





--
View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4792320.html
Sent from the Moose mailing list archive at Nabble.com.
_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev




--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: RTPNGExporter - review needed

abergel
In reply to this post by Jan Blizničenko
Hi!

It took me some time. I have included your PNG exporter in Roassal.

Cheers,
Alexandre


> On Nov 14, 2014, at 1:06 PM, Jan B. <[hidden email]> wrote:
>
> Thanks, however, in my exporter is exactly same problem as in yours, just
> where your stops creating files, my creates just white background.
> Interesting thing is that sometimes when it is unable to export, I save and
> quit Pharo, reopen and it exports fine. I would say something about memory
> related something, but when I opened 500 windows, it did not stop working
> because of that.
> Plus my exporting via morph seems to have another limitation, which is 10000
> px on width and height, anything beyond it gets cropped.
> Anyway, here it is, just updated with scaling down when too large, few fixes
> (like exporting canvas which is not open anywhere):
> http://www.mediafire.com/view/7bl4eg9qn3csici/DCTRCanvasExporter.st
>
> Jan
>
>
> abergel wrote
>> Jan, I went through your exporter, and it seems to do an interesting job.
>> I will be happy to include it in Roassal for others to have a look at it.
>>
>> Alexandre
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>> On Nov 14, 2014, at 1:03 AM, Jan B. &lt;
>
>> bliznjan@.cvut
>
>> &gt; wrote:
>>>
>>> Well, it seems mine is unable to export large pictures too, just for
>>> different reason: memory. Exported BMP for 7500*7500 px image has over
>>> 160
>>> MB and Pharo's Windows VM memory limit is only 500 MB
>>>
>>> Jan
>>>
>>>
>>> abergel wrote
>>>> no no no :-(
>>>>
>>>> It does not work for large pictures. Consider the following:
>>>>
>>>>
>>>> | b |
>>>> b := RTMondrianViewBuilder new.
>>>> b shape rectangle
>>>> withBorder;
>>>> width: [ :cls | cls numberOfVariables * 5];
>>>> height: #numberOfMethods;
>>>> linearFillColor: #numberOfLinesOfCode within: RTObject
>>>> withAllSubclasses.
>>>> b nodes: (Object withAllSubclasses copyFrom: 1 to: 3000).
>>>> b edgesFrom: #superclass.
>>>> b treeLayout.
>>>> b build.
>>>> ^ b view
>>>>
>>>> Nothing gets on the disk when you save :-(
>>>>
>>>> Jan B. sent me a morphic based exporter.
>>>>
>>>> Alexandre
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel  http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>> _______________________________________________
>>>> Moose-dev mailing list
>>>
>>>> Moose-dev@.unibe
>>>
>>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>>
>>>
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790146.html
>>> Sent from the Moose mailing list archive at Nabble.com.
>>> _______________________________________________
>>> Moose-dev mailing list
>>>
>
>> Moose-dev@.unibe
>
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>
>> Moose-dev@.unibe
>
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
>
>
>
>
> --
> View this message in context: http://forum.world.st/RTPNGExporter-review-needed-tp4789868p4790238.html
> Sent from the Moose mailing list archive at Nabble.com.
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
12