Re: 7.7.1 compare tool: Missing menu items due toshortPrintString

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: 7.7.1 compare tool: Missing menu items due toshortPrintString

Steven Kelly
Holger Kleinsorgen wrote:
> some menu items like "revert" are missing in the new compare
> tool because there's a packaging problem:
>
> AbstractComparisonRollupView>>storeObjectVersionLabel sends
> #shortPrintString to timestamps, but is only implement for
> Date and Time in the base image.
>
> Timestamp>>shortPrintString is implemented in SUnitToo(ls)...

Great catch! And that probably explains why Travis and I have never
understood each other about this issue - I don't have SUnitToo(ls)
loaded, so I keep asking why Revert still hasn't been added to the
menus, and he thinks I'm nuts because it's been there for him all along!

The real culprit is maybe the overly broad handling of
MessageNotUnderstood in Menu>>menuItems:with:forMenu:. Might be better
to check "aGenerator respondsTo: eachMenuPragma selector" instead.

Hmm, the comment in Object>>respondsTo: is also wrong - it says it's for
the receiver's class's methodDict, but it's actually for any implementor
in the class or its superclasses.

Cheers,
Steve

_______________________________________________
vwnc mailing list
[hidden email]
http://lists.cs.uiuc.edu/mailman/listinfo/vwnc