Re: [COTDC] 80#2 - RBSubclassOfClassToRename

classic Classic list List threaded Threaded
2 messages Options
laurent laffont laurent laffont
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [COTDC] 80#2 - RBSubclassOfClassToRename


Today: RBSubclassOfClassToRename

Laurent


On Mon, Sep 5, 2011 at 9:55 PM, laurent laffont <[hidden email]> wrote:
    Today:  CategoryEnvironment


Comment Of The Day Contest - One Day One Comment
Rules: 
#1: Each day a not commented class is elected. Each day the best comment will be integrated with name of the author(s).
#2: If you cannot comment it, deprecate it.
Laurent
 

Sean P. DeNigris Sean P. DeNigris
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [COTDC] 80#2 - RBSubclassOfClassToRename

There is some mismatch between intention and expression here. This class is used in RBRenameClassTest, but it is also used in ProtectInstanceVariableRefactoring, where there is no subclassing or renaming to be found.

Maybe it should either be renamed or the ProtectInstanceVariableRefactoring split out into another class.

Also, maybe Test categories should be initially excluded from COTDC. This class seems like a very low priority and probably doesn't need a comment at all.

Sean
Loading...