Re: Collection Test for ROTreeMapLayout

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Collection Test for ROTreeMapLayout

Tudor Girba-2
Hi Alex,

Right now, Versionner makes the #development version point to an actual version, and this breaks the flow in Moose, especially when we commit something to Roassal. Could you change the behavior such that #development point to the baseline associated with the current version?

Cheers,
Doru


On Wed, Mar 20, 2013 at 3:32 PM, Alexandre Bergel <[hidden email]> wrote:
Yep, it is part of 1.287.

Thanks Doru!

Alexandre


On Mar 20, 2013, at 5:13 AM, Dennis Schenk <[hidden email]> wrote:

> Hi Alexandre,
>
> Just saw that Tudor already did what I suggested. Nevermind then :)
>
> Cheers,
> Dennis
>
>
> On Wed, Mar 20, 2013 at 9:44 AM, Dennis Schenk <[hidden email]> wrote:
> Hi Alexandre,
>
> I think we should remove the test testEdgeDrivenLayoutingOfCollectionClass from ROTreeMapLayoutTest, since, as you pointed out correctly, it is based on something that can change. Meaning if something changes within the Collection class hierarchy, we would have to adapt the test, which is not desirable.
>
> I would suggest to remove the test. I will think about creating another one which tests the special case we had with the collection subclass treemap.
>
> Cheers,
> Dennis
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






--

"Every thing has its own flow"

_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Collection Test for ROTreeMapLayout

abergel
I will try to change this. Currently I am migrating Roassal to SmalltalkHub. More about this soon.

Alexandre


On Mar 20, 2013, at 10:38 AM, Tudor Girba <[hidden email]> wrote:

> Hi Alex,
>
> Right now, Versionner makes the #development version point to an actual version, and this breaks the flow in Moose, especially when we commit something to Roassal. Could you change the behavior such that #development point to the baseline associated with the current version?
>
> Cheers,
> Doru
>
>
> On Wed, Mar 20, 2013 at 3:32 PM, Alexandre Bergel <[hidden email]> wrote:
> Yep, it is part of 1.287.
>
> Thanks Doru!
>
> Alexandre
>
>
> On Mar 20, 2013, at 5:13 AM, Dennis Schenk <[hidden email]> wrote:
>
> > Hi Alexandre,
> >
> > Just saw that Tudor already did what I suggested. Nevermind then :)
> >
> > Cheers,
> > Dennis
> >
> >
> > On Wed, Mar 20, 2013 at 9:44 AM, Dennis Schenk <[hidden email]> wrote:
> > Hi Alexandre,
> >
> > I think we should remove the test testEdgeDrivenLayoutingOfCollectionClass from ROTreeMapLayoutTest, since, as you pointed out correctly, it is based on something that can change. Meaning if something changes within the Collection class hierarchy, we would have to adapt the test, which is not desirable.
> >
> > I would suggest to remove the test. I will think about creating another one which tests the special case we had with the collection subclass treemap.
> >
> > Cheers,
> > Dennis
> >
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
>
> --
> www.tudorgirba.com
>
> "Every thing has its own flow"

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Collection Test for ROTreeMapLayout

abergel
In reply to this post by Tudor Girba-2
Hi Doru,

> Right now, Versionner makes the #development version point to an actual version, and this breaks the flow in Moose, especially when we commit something to Roassal. Could you change the behavior such that #development point to the baseline associated with the current version?

I have now fixed Versionner to follow your proposal. I did a couple of commits of Roassal. Can you check please Moose loads properly?

I wish Metacello could be easy to write unit tests for.

Alexandre



>
>
> On Wed, Mar 20, 2013 at 3:32 PM, Alexandre Bergel <[hidden email]> wrote:
> Yep, it is part of 1.287.
>
> Thanks Doru!
>
> Alexandre
>
>
> On Mar 20, 2013, at 5:13 AM, Dennis Schenk <[hidden email]> wrote:
>
> > Hi Alexandre,
> >
> > Just saw that Tudor already did what I suggested. Nevermind then :)
> >
> > Cheers,
> > Dennis
> >
> >
> > On Wed, Mar 20, 2013 at 9:44 AM, Dennis Schenk <[hidden email]> wrote:
> > Hi Alexandre,
> >
> > I think we should remove the test testEdgeDrivenLayoutingOfCollectionClass from ROTreeMapLayoutTest, since, as you pointed out correctly, it is based on something that can change. Meaning if something changes within the Collection class hierarchy, we would have to adapt the test, which is not desirable.
> >
> > I would suggest to remove the test. I will think about creating another one which tests the special case we had with the collection subclass treemap.
> >
> > Cheers,
> > Dennis
> >
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
>
> --
> www.tudorgirba.com
>
> "Every thing has its own flow"

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Collection Test for ROTreeMapLayout

Tudor Girba-2
Hi Alex,

Moose loads every time there is a commit in most of the relevant repositories :).

If you publish something in Roassal on STHub, a new build will be triggered:
- first, https://ci.inria.fr/moose/job/roassal/
- and then, https://ci.inria.fr/moose/job/moose-latest-dev-4.8/

And a Moose build happens every second hour even if there is no commit.

Cheers,
Doru


On Mar 31, 2013, at 6:11 PM, Alexandre Bergel <[hidden email]> wrote:

> Hi Doru,
>
>> Right now, Versionner makes the #development version point to an actual version, and this breaks the flow in Moose, especially when we commit something to Roassal. Could you change the behavior such that #development point to the baseline associated with the current version?
>
> I have now fixed Versionner to follow your proposal. I did a couple of commits of Roassal. Can you check please Moose loads properly?
>
> I wish Metacello could be easy to write unit tests for.
>
> Alexandre
>
>
>
>>
>>
>> On Wed, Mar 20, 2013 at 3:32 PM, Alexandre Bergel <[hidden email]> wrote:
>> Yep, it is part of 1.287.
>>
>> Thanks Doru!
>>
>> Alexandre
>>
>>
>> On Mar 20, 2013, at 5:13 AM, Dennis Schenk <[hidden email]> wrote:
>>
>>> Hi Alexandre,
>>>
>>> Just saw that Tudor already did what I suggested. Nevermind then :)
>>>
>>> Cheers,
>>> Dennis
>>>
>>>
>>> On Wed, Mar 20, 2013 at 9:44 AM, Dennis Schenk <[hidden email]> wrote:
>>> Hi Alexandre,
>>>
>>> I think we should remove the test testEdgeDrivenLayoutingOfCollectionClass from ROTreeMapLayoutTest, since, as you pointed out correctly, it is based on something that can change. Meaning if something changes within the Collection class hierarchy, we would have to adapt the test, which is not desirable.
>>>
>>> I would suggest to remove the test. I will think about creating another one which tests the special case we had with the collection subclass treemap.
>>>
>>> Cheers,
>>> Dennis
>>>
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>>
>> --
>> www.tudorgirba.com
>>
>> "Every thing has its own flow"
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>

--
www.tudorgirba.com

"Every now and then stop and ask yourself if the war you're fighting is the right one."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Collection Test for ROTreeMapLayout

abergel
Oh! Excellent! I did not know that. Not really designed to curb down carbon emission but really handy!

Alexandre


On Mar 31, 2013, at 11:47 AM, Tudor Girba <[hidden email]> wrote:

> Hi Alex,
>
> Moose loads every time there is a commit in most of the relevant repositories :).
>
> If you publish something in Roassal on STHub, a new build will be triggered:
> - first, https://ci.inria.fr/moose/job/roassal/
> - and then, https://ci.inria.fr/moose/job/moose-latest-dev-4.8/
>
> And a Moose build happens every second hour even if there is no commit.
>
> Cheers,
> Doru
>
>
> On Mar 31, 2013, at 6:11 PM, Alexandre Bergel <[hidden email]> wrote:
>
>> Hi Doru,
>>
>>> Right now, Versionner makes the #development version point to an actual version, and this breaks the flow in Moose, especially when we commit something to Roassal. Could you change the behavior such that #development point to the baseline associated with the current version?
>>
>> I have now fixed Versionner to follow your proposal. I did a couple of commits of Roassal. Can you check please Moose loads properly?
>>
>> I wish Metacello could be easy to write unit tests for.
>>
>> Alexandre
>>
>>
>>
>>>
>>>
>>> On Wed, Mar 20, 2013 at 3:32 PM, Alexandre Bergel <[hidden email]> wrote:
>>> Yep, it is part of 1.287.
>>>
>>> Thanks Doru!
>>>
>>> Alexandre
>>>
>>>
>>> On Mar 20, 2013, at 5:13 AM, Dennis Schenk <[hidden email]> wrote:
>>>
>>>> Hi Alexandre,
>>>>
>>>> Just saw that Tudor already did what I suggested. Nevermind then :)
>>>>
>>>> Cheers,
>>>> Dennis
>>>>
>>>>
>>>> On Wed, Mar 20, 2013 at 9:44 AM, Dennis Schenk <[hidden email]> wrote:
>>>> Hi Alexandre,
>>>>
>>>> I think we should remove the test testEdgeDrivenLayoutingOfCollectionClass from ROTreeMapLayoutTest, since, as you pointed out correctly, it is based on something that can change. Meaning if something changes within the Collection class hierarchy, we would have to adapt the test, which is not desirable.
>>>>
>>>> I would suggest to remove the test. I will think about creating another one which tests the special case we had with the collection subclass treemap.
>>>>
>>>> Cheers,
>>>> Dennis
>>>>
>>>
>>> --
>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>> Alexandre Bergel  http://www.bergel.eu
>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> www.tudorgirba.com
>>>
>>> "Every thing has its own flow"
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>
> --
> www.tudorgirba.com
>
> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>
>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Collection Test for ROTreeMapLayout

stephane ducasse

On Mar 31, 2013, at 6:59 PM, Alexandre Bergel <[hidden email]> wrote:

> Oh! Excellent! I did not know that. Not really designed to curb down carbon emission but really handy!

keep this kind of checks for when you take an airplane, because running a build on a server or having the server idle
should not produce more CO2 than the handling of this email.

>
> Alexandre
>
>
> On Mar 31, 2013, at 11:47 AM, Tudor Girba <[hidden email]> wrote:
>
>> Hi Alex,
>>
>> Moose loads every time there is a commit in most of the relevant repositories :).
>>
>> If you publish something in Roassal on STHub, a new build will be triggered:
>> - first, https://ci.inria.fr/moose/job/roassal/
>> - and then, https://ci.inria.fr/moose/job/moose-latest-dev-4.8/
>>
>> And a Moose build happens every second hour even if there is no commit.
>>
>> Cheers,
>> Doru
>>
>>
>> On Mar 31, 2013, at 6:11 PM, Alexandre Bergel <[hidden email]> wrote:
>>
>>> Hi Doru,
>>>
>>>> Right now, Versionner makes the #development version point to an actual version, and this breaks the flow in Moose, especially when we commit something to Roassal. Could you change the behavior such that #development point to the baseline associated with the current version?
>>>
>>> I have now fixed Versionner to follow your proposal. I did a couple of commits of Roassal. Can you check please Moose loads properly?
>>>
>>> I wish Metacello could be easy to write unit tests for.
>>>
>>> Alexandre
>>>
>>>
>>>
>>>>
>>>>
>>>> On Wed, Mar 20, 2013 at 3:32 PM, Alexandre Bergel <[hidden email]> wrote:
>>>> Yep, it is part of 1.287.
>>>>
>>>> Thanks Doru!
>>>>
>>>> Alexandre
>>>>
>>>>
>>>> On Mar 20, 2013, at 5:13 AM, Dennis Schenk <[hidden email]> wrote:
>>>>
>>>>> Hi Alexandre,
>>>>>
>>>>> Just saw that Tudor already did what I suggested. Nevermind then :)
>>>>>
>>>>> Cheers,
>>>>> Dennis
>>>>>
>>>>>
>>>>> On Wed, Mar 20, 2013 at 9:44 AM, Dennis Schenk <[hidden email]> wrote:
>>>>> Hi Alexandre,
>>>>>
>>>>> I think we should remove the test testEdgeDrivenLayoutingOfCollectionClass from ROTreeMapLayoutTest, since, as you pointed out correctly, it is based on something that can change. Meaning if something changes within the Collection class hierarchy, we would have to adapt the test, which is not desirable.
>>>>>
>>>>> I would suggest to remove the test. I will think about creating another one which tests the special case we had with the collection subclass treemap.
>>>>>
>>>>> Cheers,
>>>>> Dennis
>>>>>
>>>>
>>>> --
>>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>>> Alexandre Bergel  http://www.bergel.eu
>>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> www.tudorgirba.com
>>>>
>>>> "Every thing has its own flow"
>>>
>>> --
>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>> Alexandre Bergel  http://www.bergel.eu
>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>
>>>
>>>
>>
>> --
>> www.tudorgirba.com
>>
>> "Every now and then stop and ask yourself if the war you're fighting is the right one."
>>
>>
>>
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev


_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev