Smalltalk › Amber Smalltalk

Re: Helios Bug

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Herby Vojčík

Re: Helios Bug

Paul Wilke wrote:
> Hi Herby,
> thank you for your help on this.
> One last question, maybe you could answer it in the issue or the mailing
> list so that it helps others too.
>
> How do I actually update my project to use our fix?

I would do `rm -f bower_components` / `del /s/q bower_components`
followed by `bower install`. Maybe there is softer way, but those often
fail in so many details, that I just reget all the dependencies.

> Kind regards, and many thanks,
> Paul
>
>
>
>
>> Am 29.02.2016 um 15:52 schrieb Paul Wilke <[hidden email]
>> <mailto:[hidden email]>>:
>>
>> sure, I wasn’t thinking. just thought the old version would be solving
>> the issue, so I reverted.
>>
>> Ok this solves the issue you are right:
>>
>> renderOn: html
>> wrapper := html div
>> class: self cssClass;
>> at: 'tabindex' put: '0';
>> onBlur: [ self wrapper asJQuery removeClass: self focusClass ];
>> onFocus: [ self wrapper asJQuery addClass: self focusClass ];
>> yourself.
>> "must do this later, as renderContentOn may want to use self wrapper"
>> wrapper with: [ self renderContentOn: html ]
>>
>> I send you a pull request
>>
>>> Am 29.02.2016 um 15:36 schrieb Herby Vojčík <[hidden email]
>>> <mailto:[hidden email]>>:
>>>
>>>
>>>
>>> Paul Wilke wrote:
>>>> yeah was the wrong reference.
>>>>
>>>> if I get you right I tried:
>>>>
>>>> renderOn: html
>>>> wrapper := html div
>>>> class: self cssClass;
>>>> with: [ self renderContentOn: html ];
>>>> yourself.
>>>> "must do this later, as renderContentOn may want to use self wrapper"
>>>> "wrapper with: [ self renderContentOn: html ]“
>>>
>>> Why the comment here? This is ok.
>>>
>>> The method that is commented in the commit comments should be fixed
>>> similarly.
>>>
>>>> but the same problem occurs
>>>>
>>>>
>>>>> Am 29.02.2016 um 15:07 schrieb Paul Wilke <[hidden email]
>>>>> <mailto:[hidden email]> <mailto:[hidden email]>>:
>>>>>
>>>>> Hi Herbert,
>>>>> sorry I have overscrolled your message: Maybe this renderContentOn:
>>>>> should happen after the assignment, similarly to what 3233e94
>>>>> <https://github.com/amber-smalltalk/helios/commit/3233e94354317e696394b1be856e548c291bd0a4>did.
>>>>>
>>>>> But what should I try to fix? Now I don’t get you :-/
>>>>> Please give me a closer hint and I try.
>>>>>
>>>>> Kind regards,
>>>>>
>>>>>
>>>>> Paul Wilke
>>>>>
>>>>> ---
>>>>> wilke@it
>>> sys24.de <http://sys24.de> <mailto:[hidden email]>
>>>>> *fre.iburg it systems*
>>>>> Engelbergerstraße 19 · 79106 Freiburg
>>>>> Geschäftsführung: Jens Iburg
>>>>> USt-IdNr. DE236037674
>>>>> www.itsys24.de <http://www.itsys24.de> <http://www.itsys24.de/>·
>>>>> www.t-crm.de <http://www.t-crm.de> <http://www.t-crm.de/>
>>>>>
>>>>
>>
>

--
You received this message because you are subscribed to the Google Groups "amber-lang" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
For more options, visit https://groups.google.com/d/optout.

Herby Vojčík

Re: Helios Bug

Herby Vojčík wrote:

>
>
> Paul Wilke wrote:
>> Hi Herby,
>> thank you for your help on this.
>> One last question, maybe you could answer it in the issue or the mailing
>> list so that it helps others too.
>>
>> How do I actually update my project to use our fix?
>
> I would do `rm -f bower_components` / `del /s/q bower_components`

Fix: `rd /s/q bower_components`

> followed by `bower install`. Maybe there is softer way, but those often
> fail in so many details, that I just reget all the dependencies.
>
>> Kind regards, and many thanks,
>> Paul
>>
>>
>>
>>
>>> Am 29.02.2016 um 15:52 schrieb Paul Wilke <[hidden email]
>>> <mailto:[hidden email]>>:
>>>
>>> sure, I wasn’t thinking. just thought the old version would be solving
>>> the issue, so I reverted.
>>>
>>> Ok this solves the issue you are right:
>>>
>>> renderOn: html
>>> wrapper := html div
>>> class: self cssClass;
>>> at: 'tabindex' put: '0';
>>> onBlur: [ self wrapper asJQuery removeClass: self focusClass ];
>>> onFocus: [ self wrapper asJQuery addClass: self focusClass ];
>>> yourself.
>>> "must do this later, as renderContentOn may want to use self wrapper"
>>> wrapper with: [ self renderContentOn: html ]
>>>
>>> I send you a pull request
>>>
>>>> Am 29.02.2016 um 15:36 schrieb Herby Vojčík <[hidden email]
>>>> <mailto:[hidden email]>>:
>>>>
>>>>
>>>>
>>>> Paul Wilke wrote:
>>>>> yeah was the wrong reference.
>>>>>
>>>>> if I get you right I tried:
>>>>>
>>>>> renderOn: html
>>>>> wrapper := html div
>>>>> class: self cssClass;
>>>>> with: [ self renderContentOn: html ];
>>>>> yourself.
>>>>> "must do this later, as renderContentOn may want to use self wrapper"
>>>>> "wrapper with: [ self renderContentOn: html ]“
>>>>
>>>> Why the comment here? This is ok.
>>>>
>>>> The method that is commented in the commit comments should be fixed
>>>> similarly.
>>>>
>>>>> but the same problem occurs
>>>>>
>>>>>
>>>>>> Am 29.02.2016 um 15:07 schrieb Paul Wilke <[hidden email]
>>>>>> <mailto:[hidden email]> <mailto:[hidden email]>>:
>>>>>>
>>>>>> Hi Herbert,
>>>>>> sorry I have overscrolled your message: Maybe this renderContentOn:
>>>>>> should happen after the assignment, similarly to what 3233e94
>>>>>> <https://github.com/amber-smalltalk/helios/commit/3233e94354317e696394b1be856e548c291bd0a4>did.
>>>>>>
>>>>>>
>>>>>> But what should I try to fix? Now I don’t get you :-/
>>>>>> Please give me a closer hint and I try.
>>>>>>
>>>>>> Kind regards,
>>>>>>
>>>>>>
>>>>>> Paul Wilke
>>>>>>
>>>>>> ---
>>>>>> wilke@it
>>>> sys24.de <http://sys24.de> <mailto:[hidden email]>
>>>>>> *fre.iburg it systems*
>>>>>> Engelbergerstraße 19 · 79106 Freiburg
>>>>>> Geschäftsführung: Jens Iburg
>>>>>> USt-IdNr. DE236037674
>>>>>> www.itsys24.de <http://www.itsys24.de> <http://www.itsys24.de/>·
>>>>>> www.t-crm.de <http://www.t-crm.de> <http://www.t-crm.de/>
>>>>>>
>>>>>
>>>
>>
>

Herby Vojčík

Re: Helios Bug

In reply to this post by Herby Vojčík

Herby Vojčík wrote:

Fix: `rm -r bower_components`.