Re: Hudson build is still unstable: moose-latest-dev #254

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Hudson build is still unstable: moose-latest-dev #254

abergel
I turned one yellow test into green.
There are still 2 red and 1 yellow that I do not know why they are failing.

This stem from evaluating the following expression. They raise an error:
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 MooseModel famixCoreMetamodel.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
        stream := WriteStream on: String new.
        model := MooseModel new.
        MooseModel export: model to: stream filtredBy: ImportingContext new
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Are these methods really used? Shall we remove them?

Cheers,
Alexandre

On 26 Mar 2011, at 17:18, [hidden email] wrote:

> See <http://hudson.moosetechnology.org/job/moose-latest-dev/254/>
>
>

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Hudson build is still unstable: moose-latest-dev #254

Tudor Girba
Hi,

> I turned one yellow test into green.
> There are still 2 red and 1 yellow that I do not know why they are failing.
>
> This stem from evaluating the following expression. They raise an error:
> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> MooseModel famixCoreMetamodel.

This is actually a problem that we have with building meta-descriptions in the presence of class extensions. The idea of this method is to return a repository that contains only FAMIX-Core. However, the problem is that the Pragma reader tries to build all properties, including the extensions, and this leads to errors. Let's take an example.

- FAMIXFunction is defined in Famix-Core
- FAMIXFunction>>parentModule is defined in Famix-C
- This property has as type FAMIXModule
- FAMIXModule is defined in Famix-C

So, when requesting famixCoreMetamodel, FAMIXModule is not present, but FAMIXFunction>>parentModule needs it.

The solution is to define proper properties as extensions, too.

In any case, the famixCoreMetamodel does not really belong in MooseModel. We should move it in the Famix-Specifications.

> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> stream := WriteStream on: String new.
> model := MooseModel new.
> MooseModel export: model to: stream filtredBy: ImportingContext new

I understand the goal of the filteredBy: methods, but I do not see how they could work. So, we should remove them.

Cyrille, it looks like you wrote these methods in the context of the Moose-Wizard. Could you take a look at these and tell us if you still need them?

Cheers,
Doru


> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>
> Are these methods really used? Shall we remove them?
>
> Cheers,
> Alexandre
>
> On 26 Mar 2011, at 17:18, [hidden email] wrote:
>
>> See <http://hudson.moosetechnology.org/job/moose-latest-dev/254/>
>>
>>
>
> --
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
www.tudorgirba.com

"Problem solving efficiency grows with the abstractness level of problem understanding."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Hudson build is still unstable: moose-latest-dev #254

Tudor Girba
I removed the *export*filtredBy: methods and the related tests.

Cheers,
Doru


On 27 Mar 2011, at 00:42, Tudor Girba wrote:

> Hi,
>
>> I turned one yellow test into green.
>> There are still 2 red and 1 yellow that I do not know why they are failing.
>>
>> This stem from evaluating the following expression. They raise an error:
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>> MooseModel famixCoreMetamodel.
>
> This is actually a problem that we have with building meta-descriptions in the presence of class extensions. The idea of this method is to return a repository that contains only FAMIX-Core. However, the problem is that the Pragma reader tries to build all properties, including the extensions, and this leads to errors. Let's take an example.
>
> - FAMIXFunction is defined in Famix-Core
> - FAMIXFunction>>parentModule is defined in Famix-C
> - This property has as type FAMIXModule
> - FAMIXModule is defined in Famix-C
>
> So, when requesting famixCoreMetamodel, FAMIXModule is not present, but FAMIXFunction>>parentModule needs it.
>
> The solution is to define proper properties as extensions, too.
>
> In any case, the famixCoreMetamodel does not really belong in MooseModel. We should move it in the Famix-Specifications.
>
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>> stream := WriteStream on: String new.
>> model := MooseModel new.
>> MooseModel export: model to: stream filtredBy: ImportingContext new
>
> I understand the goal of the filteredBy: methods, but I do not see how they could work. So, we should remove them.
>
> Cyrille, it looks like you wrote these methods in the context of the Moose-Wizard. Could you take a look at these and tell us if you still need them?
>
> Cheers,
> Doru
>
>
>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>
>> Are these methods really used? Shall we remove them?
>>
>> Cheers,
>> Alexandre
>>
>> On 26 Mar 2011, at 17:18, [hidden email] wrote:
>>
>>> See <http://hudson.moosetechnology.org/job/moose-latest-dev/254/>
>>>
>>>
>>
>> --
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>
>>
>>
>>
>>
>> _______________________________________________
>> Moose-dev mailing list
>> [hidden email]
>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>
> --
> www.tudorgirba.com
>
> "Problem solving efficiency grows with the abstractness level of problem understanding."
>
>
>

--
www.tudorgirba.com

"Be rather willing to give than demanding to get."




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev
Reply | Threaded
Open this post in threaded view
|

Re: Hudson build is still unstable: moose-latest-dev #254

abergel
Excellent!
So, nothing to do from my side I understand.

Alexandre


On 27 Mar 2011, at 04:12, Tudor Girba wrote:

> I removed the *export*filtredBy: methods and the related tests.
>
> Cheers,
> Doru
>
>
> On 27 Mar 2011, at 00:42, Tudor Girba wrote:
>
>> Hi,
>>
>>> I turned one yellow test into green.
>>> There are still 2 red and 1 yellow that I do not know why they are failing.
>>>
>>> This stem from evaluating the following expression. They raise an error:
>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>> MooseModel famixCoreMetamodel.
>>
>> This is actually a problem that we have with building meta-descriptions in the presence of class extensions. The idea of this method is to return a repository that contains only FAMIX-Core. However, the problem is that the Pragma reader tries to build all properties, including the extensions, and this leads to errors. Let's take an example.
>>
>> - FAMIXFunction is defined in Famix-Core
>> - FAMIXFunction>>parentModule is defined in Famix-C
>> - This property has as type FAMIXModule
>> - FAMIXModule is defined in Famix-C
>>
>> So, when requesting famixCoreMetamodel, FAMIXModule is not present, but FAMIXFunction>>parentModule needs it.
>>
>> The solution is to define proper properties as extensions, too.
>>
>> In any case, the famixCoreMetamodel does not really belong in MooseModel. We should move it in the Famix-Specifications.
>>
>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>> stream := WriteStream on: String new.
>>> model := MooseModel new.
>>> MooseModel export: model to: stream filtredBy: ImportingContext new
>>
>> I understand the goal of the filteredBy: methods, but I do not see how they could work. So, we should remove them.
>>
>> Cyrille, it looks like you wrote these methods in the context of the Moose-Wizard. Could you take a look at these and tell us if you still need them?
>>
>> Cheers,
>> Doru
>>
>>
>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>>
>>> Are these methods really used? Shall we remove them?
>>>
>>> Cheers,
>>> Alexandre
>>>
>>> On 26 Mar 2011, at 17:18, [hidden email] wrote:
>>>
>>>> See <http://hudson.moosetechnology.org/job/moose-latest-dev/254/>
>>>>
>>>>
>>>
>>> --
>>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>>> Alexandre Bergel  http://www.bergel.eu
>>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Moose-dev mailing list
>>> [hidden email]
>>> https://www.iam.unibe.ch/mailman/listinfo/moose-dev
>>
>> --
>> www.tudorgirba.com
>>
>> "Problem solving efficiency grows with the abstractness level of problem understanding."
>>
>>
>>
>
> --
> www.tudorgirba.com
>
> "Be rather willing to give than demanding to get."
>
>
>
>
> _______________________________________________
> Moose-dev mailing list
> [hidden email]
> https://www.iam.unibe.ch/mailman/listinfo/moose-dev

--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.





_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.iam.unibe.ch/mailman/listinfo/moose-dev