Re: Issue 113 in glassdb: UTF8 encoding and Pier

Updates:
        Labels: -Milestone-3.0 Milestone-1.0-beta.8.5

Comment #5 on issue 113 by [hidden email]: UTF8 encoding and Pier
http://code.google.com/p/glassdb/issues/detail?id=113

I think Norbert may have made these changes in base Pier

Comment #6 on issue 113 by norbert.hartl: UTF8 encoding and Pier
http://code.google.com/p/glassdb/issues/detail?id=113

Yes, that is right.


Pier-Model-lr.393.mcz
Author: Lukas Renggli
Timestamp: 9 October 2010 11:34:48 am
UUID: e26211c8-e382-44d8-bb18-7222fd290a32
Ancestors: Pier-Model-lr.392.mcz
Message: integrated:

I like to use unicode characters in pier url paths. Nowadays encodeForHTTP  
changed in pharo and squeak to do utf-8 url-safe-encoding by default. I  
updated the implementation in the gemstone squeak package to do the same.  
So principal there is no need to be very restrictive in pier names.

I did some tests with changing the implementation to

PRPath>>isValidName: aString
^ aString isNil not
and: [ aString isEmpty not
and: [ aString ~= self parentStructure
and: [ aString ~= self currentStructure
and: [ aString allSatisfy: [ :char | char isAlphaNumeric or: [self  
validCharacters includes: char] ] ] ] ] ]

and it works well. PRPath>>validCharacters: could be reduced to just  
contain '-._'. Ok, the naming needs probably to be adjusted. But I think it  
is worth the change.

Norbert

Comment #7 on issue 113 by norbert.hartl: UTF8 encoding and Pier
http://code.google.com/p/glassdb/issues/detail?id=113

Looking a second time at it I think it should be Pier-Model-lr.394.mcz  
where the naming of the pages has been improved. Just for the record

Updates:
        Status: Fixed

Comment #8 on issue 113 by [hidden email]: UTF8 encoding and Pier
http://code.google.com/p/glassdb/issues/detail?id=113

Pier2.0.7 is where the change was picked up