Re: Issue 1686 in pharo: resetTo:1 in newFrom: aCollection

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1686 in pharo: resetTo:1 in newFrom: aCollection

pharo

Comment #2 on issue 1686 by [hidden email]: resetTo:1 in newFrom:  
aCollection
http://code.google.com/p/pharo/issues/detail?id=1686

The main difference between Squeak trunk and Pharo #14127 lies in the  
definition of #reset. Squeak resetTo: 1, and due to this, putting resetTo:  
1 in #new #new: would be useless.

I believe that this change made to #reset is important for better  
optimization of speed.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1686 in pharo: resetTo:1 in newFrom: aCollection

pharo

Comment #3 on issue 1686 by [hidden email]: resetTo:1 in newFrom:  
aCollection
http://code.google.com/p/pharo/issues/detail?id=1686

Why the change of #reset is necessary is explained in issue 4596.
It is now high time to finish this work.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1686 in pharo: resetTo:1 in newFrom: aCollection

pharo
Updates:
        Status: FixProposed

Comment #4 on issue 1686 by [hidden email]: resetTo:1 in newFrom:  
aCollection
http://code.google.com/p/pharo/issues/detail?id=1686

See SLICE-Issue-1686-fastup-OrderedCollection-reset-nice.1
Author: nice
Time: 9 September 2011, 10:40:43 pm
UUID: 7f205c68-8d3f-4cdb-8643-04b2dca13766
Ancestors:
Dependencies: Collections-Sequenceable-nice.100

Fast up OrderedCollection by initializing the firstIndex to 1.
This is obtained by changing #reset.
With this change, it is not necessary to call resetTo: 1 in #newFrom:  
contrarily to what was done in Squeak.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1686 in pharo: resetTo:1 in newFrom: aCollection

pharo
Updates:
        Status: Closed

Comment #5 on issue 1686 by [hidden email]: resetTo:1 in newFrom:  
aCollection
http://code.google.com/p/pharo/issues/detail?id=1686

in 14128


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1686 in pharo: resetTo:1 in newFrom: aCollection

pharo
Updates:
        Labels: MigratedToFogBugz

Comment #6 on issue 1686 by [hidden email]: resetTo:1 in newFrom:  
aCollection
http://code.google.com/p/pharo/issues/detail?id=1686#c6

Issue migrated to https://pharo.fogbugz.com/f/cases/1734

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker