Re: Issue 1907 in pharo: Set with nil

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Status: Started

Comment #24 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Labels: Milestone-1.3

Comment #25 on issue 1907 by marianopeck: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

So guille, is this ready for integrate?  If true, I tag it so that we can  
integrate it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #26 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

I did it 6 months ago, it was working and tests were green.  I have to  
verify it right now, but I don't think too much has changed in Set's  
code ;)...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #27 on issue 1907 by marianopeck: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

Ok. When you can, test it. If it works tag it as "FixToInclude" so that we  
can have it integrate it and make your GLorp port easier ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #28 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

How does that make porting Glorp easier?
VW does not accept nil in Sets :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #29 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

it doesn't makes any difference.
As long as your application code not relying on fact that Sets can't  
include nils, i.e.:

[
#(1 2 3 nil ) asSet ] on: Error do: [:ex | self doSomethingElse ]

your code will work exactly as before. Because all existing code simply  
avoids putting nils into sets.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Cc: [hidden email]

Comment #30 on issue 1907 by marianopeck: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

"How does that make porting Glorp easier?
VW does not accept nil in Sets :)"   no?
wow....so I don't understand

Guille, if you take a look I pay you a beer at ESUG.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #31 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

Actually, in VW, if you try to add a nil to a Set it just does not  
complains and does not do anything.  In Pharo it throws an exception :).  
I'll review it now.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #32 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

That's very very different from returning true later on if asked includes:  
nil though.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #33 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

True, I'm not arguing about if it's useful or not.  It should be a nice  
discussion in the list, since this issue is here since a year ago, the  
slices are 6 month old and maybe we don't need this and this issue should  
be marked as invalid.

So, I'm reviewing the code and pushing just to take a decision ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #34 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

SLICE-Issue-1907-SetWithNilTests-GuillermoPolito.2

loads fine in pharo 1.3 13201


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #35 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

I had to do some little changes, but

SLICE-Issue-1907-SetWithNilTests-GuillermoPolito.3
SLICE-Issue-1907-SetsWithNilsWithNegativeTally-GuillermoPolito.3

are working on pharo 1.3 :)

I'll ask for review and discussion in the list


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Status: FixProposed

Comment #36 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #37 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

we will look at it with igor


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #38 on issue 1907 by marianopeck: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

thanks Stef. Because if it is not integrated now they we will have a lot of  
effort again to integrate it in a future pharo...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Labels: Type-Feature

Comment #39 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #40 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

So we put this in 1.3 or as the first thing in 1.4?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo

Comment #41 on issue 1907 by marianopeck: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

if possible I would have it for 1.3. Otherwise it will be an effort again  
to put it in 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Status: ReviewNeeded

Comment #42 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 1907 in pharo: Set with nil

pharo
Updates:
        Labels: -Milestone-1.3 Milestone-1.4

Comment #43 on issue 1907 by [hidden email]: Set with nil
http://code.google.com/p/pharo/issues/detail?id=1907

I think we should move this to 1.4... because it is a deep change that  
needs to be tested.

We should do it as the first thing in 1.4


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
12