Re: Issue 2063 in pharo: NumberTest

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2063 in pharo: NumberTest

pharo
Updates:
        Labels: -Type-Squeak Type-Feature Milestone-2.0

Comment #7 on issue 2063 by [hidden email]: NumberTest
http://code.google.com/p/pharo/issues/detail?id=2063

I propose to distinguish:
- #readSmalltalkSyntaxFrom: to just read strict Smalltalk number syntax (as  
defined by Pharo)
- #readFrom: to use more liberal and tolerant syntax (with the help of  
ExtendedNumberParser)

Reading numbers with liberal extended syntax can be usefull for  
applications.
It would also reduce useless differences with Squeak.
Note that VW has also defined #readSmalltalkSyntaxFrom:.

Packages like PetitParser would then use the unambiguous and ubiquitous  
#readSmalltalkSyntaxFrom: form.



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2063 in pharo: NumberTest

pharo
Updates:
        Status: FixReviewNeeded

Comment #8 on issue 2063 by [hidden email]: NumberTest
http://code.google.com/p/pharo/issues/detail?id=2063

SLICE is in inbox, but I noticed that many methods in Collections-String  
and Collections-Text were marked as changed, though I only added a single  
method: #asSmalltalkNumber. It is probably due to an unclean package  
refactoring independent of me.

Name: SLICE-Issue-2063-ExtendedNumberSyntax-nice.1
Author: nice
Time: 28 April 2012, 6:00:45.914 pm
UUID: e07707d3-c89e-45d9-a2eb-1931308cbe0a
Ancestors:
Dependencies: Kernel-nice.1059, Collections-Text-nice.78,  
KernelTests-nice.396, Collections-Strings-nice.208

http://code.google.com/p/pharo/issues/detail?id=2063

Use ExtendedNumberParser (extended number syntax) for String>>asNumber and  
Number class>>#readFrom:

Introduce String>>asSmalltalkNumber and Number  
class>>#readSmalltalkSyntaxFrom: when we want to restrict to Smalltalk  
syntax.

Fix the KernelTests to reflect those changes.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2063 in pharo: NumberTest

pharo
Updates:
        Status: FixToInclude

Comment #9 on issue 2063 by [hidden email]: NumberTest
http://code.google.com/p/pharo/issues/detail?id=2063

looks good, Kernel Number tests are green


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2063 in pharo: NumberTest

pharo
Updates:
        Status: Integrated

Comment #10 on issue 2063 by [hidden email]: NumberTest
http://code.google.com/p/pharo/issues/detail?id=2063

in 2.0 037


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker