Re: Issue 2130 in pharo: cleanUpForRelease and friends should use new cleanUp protocol

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2130 in pharo: cleanUpForRelease and friends should use new cleanUp protocol

pharo

Comment #5 on issue 2130 by stephane.ducasse: cleanUpForRelease and friends  
should use new cleanUp protocol
http://code.google.com/p/pharo/issues/detail?id=2130

so what is left to do?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 2130 in pharo: cleanUpForRelease and friends should use new cleanUp protocol

pharo

Comment #6 on issue 2130 by marianopeck: cleanUpForRelease and friends  
should use new cleanUp protocol
http://code.google.com/p/pharo/issues/detail?id=2130

Everything :)
Take a look to #cleanUpForRelease or #cleanUpForProduction
Most of the stuff there, should be moved to the common protocol #cleanUp  
and #cleanUp developed by Keith and integrated also in Squeak.

So...once it is done, we can just implement in SmalltalkImage something  
like:

SmalltalkImage >> cleanUp
  self allClassesDo: [:each | each cleanUp]

and

SmalltalkImage >> cleanUp: flag
  self allClassesDo: [:each | each cleanUp: flag]


And then, in #cleanUpForRelease or #cleanUpForProduction instead of  
hardcoding all the cleanings, we just do "Smalltalk cleanUp".


at least, this is an idea.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 2130 in pharo: cleanUpForRelease and friends should use new cleanUp protocol

pharo

Comment #7 on issue 2130 by adrian.lienhard: cleanUpForRelease and friends  
should use new cleanUp protocol
http://code.google.com/p/pharo/issues/detail?id=2130

I can implement this during the text days.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 2130 in pharo: cleanUpForRelease and friends should use new cleanUp protocol

pharo

Comment #8 on issue 2130 by marianopeck: cleanUpForRelease and friends  
should use new cleanUp protocol
http://code.google.com/p/pharo/issues/detail?id=2130

Excellent Adiran. Now I was thinking that maybe it is not a good idae to  
call #cleanUp: and #cleanUp in Smalltalk image. Because maybe that cclass  
has its own cleaning. Maybe we can put the self allClassesDo: [:each | each  
cleanUp: flag]

in another method like #cleanUpAllClasses or something like that.

Finally, check on Squeak, implementors of #cleanUp and #cleanUp: because  
they did much more.