Re: Issue 2255 in pharo: fix comment and use of #flushCache

Updates:
        Summary: fix comment and use of  #flushCache
        Labels: Milestone-1.4

Comment #5 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #6 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #7 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

in 14365


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

So now we do not flush the cache when adding a method. I wonder if that is  
correct... I should read the code of the flushCache primitives.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

Ah, no, it's all fine. The only case that adding a method makes problems is  
when there is one already  in the superclass. And we search for that and  
invalidate it per compiledMethod.

If there is no method in the superclass, we do not need to flush the cache,  
as it is a pure addition with no possible other entry in the cache with the  
same name for that class.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

Would it be an idea to change the CompiledMethod/Symbol flushCache comment  
to state "This primitive must be called whenever a method is redefined or  
removed.", swapping defined for redefined?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 2255 by [hidden email]: fix comment and use of  
#flushCache
http://code.google.com/p/pharo/issues/detail?id=2255

yes, goo idea. I will change the comment.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker