Comment #7 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 What should we do with this? It is unlikely to see this happens. "self halt" is the way people put breakpoint (unfortunately) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #8 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 I would say introduce these helper methods on Halt and put the 'Object >> #halt.*' in an extension package on object. This way we might slowly move towards a less bloated Object. BTW: the same should count for `self error: 'foo'`. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #9 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 The idea to have Halt method in Object as extension is a nice idea. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #10 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 "self halt" --> "Halt here"? I think we should focus on what the Right Thing is, and not what people are used to doing. We don't care about being backward compatible, right? Alway, are real breakpoints anywhere on the horizon? _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #11 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 Fix in inbox: SLICE-Issue-2394-Halt-SeanDeNigris.1 Object * 16 methods deprecated * 5 halt methods that now forward to Halt Globals - can remove #HaltOnce and #HaltCount Halt class * methods - 5 for halting API - 3 to enable/disable haltOnce - 6 private helpers * 2 class instance variables World menu - updated to use Halt API Tests * 6 new assertions in 2 test methods * 4 test helpers for halt behavior * changed other halt tests to use the helpers _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #12 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 Issue 2621 has been merged into this issue. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: Milestone-1.4 Comment #13 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 Arg When I integrate your change the world menu is broken. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #14 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 Ok fixed it. The variable is.... was not initialized. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Closed Comment #15 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 in 14112 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #16 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 Strange, I guess you mean isHaltOnceEnabled in Halt class. It is initialized in Halt class>>initialize. Now it is initialized in class-side initialize and also lazily - which one should we keep? When checking the variable, I noticed a small comment that needs to be changed and that Halt's other class instance variable, callsUntilHaltOnCount, was set to the wrong initial value (should be zero). I'll upload a fix for all three went I hear back from you. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Workneeded Comment #17 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #18 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 send a fix and I will look at it. Sean what I did was to make sure that Halt and self halt got the same API and also that self halt is kept for backward compatibility and migration. I also did the same for deprecated: :) Stef _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Integrated Comment #19 on issue 2394 by [hidden email]: Halt http://code.google.com/p/pharo/issues/detail?id=2394 Please open a new bug report (it's very hard to follow else) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |