Re: Issue 2759 in pharo: Add OrderedDictionary

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: FixProposed

Comment #2 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo

Comment #3 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

I think if we add this we should maybe consider an ordered set as well  
(since thats basically a dict with key = value)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: MonkeyIsChecking

Comment #4 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759#c4

The Monkey is currently checking this issue. Please don't change this issue.
       
        Freeze, I said "Freeze" #@$%!!!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: ReviewNeeded

Comment #5 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759#c5

This Issue has been marked for review by Ulysse the Monkey:

Errors:
=======
        MessageNotUnderstood: GoogleAttachement>>endsWith:


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo

Comment #6 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759#c6

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
'01: GoogleAttachement(Object)>>doesNotUnderstand: #endsWith:
02: GZipReadStream class>>uncompressedFileName:
03: FileStream class>>fileIn:
04: [:aString | FileStream fileIn: aString] in [self issue changeSets
                do: [:aString | FileStream fileIn: aString].
        extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
05: Array(SequenceableCollection)>>do:
06: [self issue changeSets
                do: [:aString | FileStream fileIn: aString].
        extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
07: [aBlock value.
        testResult := self runTests.
        self removeFalseErrors] in ChangeLoader>>testChangeImpact:
08: BlockClosure>>on:do:
09: ChangeLoader>>testChangeImpact:
10: ChangeLoader>>loadCS
'


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo

Comment #7 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759#c7

This Issue has been marked for review by Ulysse the Monkey:

Monkey went bananas:
--------------------
01: GoogleAttachement(Object)>>doesNotUnderstand: #endsWith:
02: GZipReadStream class>>uncompressedFileName:
03: FileStream class>>fileIn:
04: [:aString | FileStream fileIn: aString] in [self issue changeSets
                do: [:aString | FileStream fileIn: aString].
        extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
05: Array(SequenceableCollection)>>do:
06: [self issue changeSets
                do: [:aString | FileStream fileIn: aString].
        extraTests := self dirtyPackagesTests] in ChangeLoader>>loadCS
07: [aBlock value.
        testResult := self runTests.
        self removeFalseErrors] in ChangeLoader>>testChangeImpact:
08: BlockClosure>>on:do:
09: ChangeLoader>>testChangeImpact:
10: ChangeLoader>>loadCS


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo

Comment #8 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

SmallDictionary does this already...

If anything, it could be considered whether an alternative implementation  
along the lines of  
http://objology.blogspot.com/2011/06/kicking-hash-out-of-dictionary.html 
would be faster.





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Labels: Type-Feature

Comment #9 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: FixReviewNeeded

Comment #10 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo

Comment #11 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

we really want this? we already have SmallDictionary...
Said so, maybe SmallDictionary is a bad name :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: WontFix

Comment #12 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

I think we should wait till we really need it.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: FixReviewNeeded
        Cc: [hidden email]
        Labels: Milestone-2.0

Comment #13 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
In reply to this post by pharo

Comment #15 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

Hey,

I wanted to fix that then I found OrderedIdentityDictionary in the package  
Spec-core. I needed the OrderedDictionary for the inspectors to be able to  
choose in which order the elements I added were displayed. I guess people  
will mostly use OrderedDictionary for User Iterface purpose.

So question, should OrderedIdentityDictionary be moved to collection  
package ?

I didn't find the tests for it...



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo
Updates:
        Status: WontFix

Comment #16 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2759 in pharo: Add OrderedDictionary

pharo

Comment #17 on issue 2759 by [hidden email]: Add OrderedDictionary
http://code.google.com/p/pharo/issues/detail?id=2759

see also http://code.google.com/p/pharo/issues/detail?id=7374


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker