Re: Issue 2847 in pharo: SocketStream not robuts against integer

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: FixToInclude
        Owner: [hidden email]

Comment #4 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

Name: SLICE-Issue-2847--------NickPapoulias.1


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: FixReviewNeeded

Comment #5 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

Summary:

created failing tests, fixed to:

* be able to write byteArray and search with a char
* write a string and search with an Integer(SmallInteger/Byte)

====================================================================

So for e.g Character cr is different from 13, so when you search for 13  
(instead of Character cr) it does not find it. It then waits the standard  
timeout and produces an exception. The weird part is the timeout is too  
long: 45 sec but that's another issue (sven in his implementation of  
SocketStream has it at 5 sec).

So SocketStream>>upTo: aCharacterOrByte, should actually work with  
SmallIntegers (Bytes) -- in my opinion -- this is what the argument  
suggests. So I' ve created an (initially) failing test on  
SocketStreamTest>>testUpToPassingSmallInteger, which I fixed by demanding  
asCharacter to aCharacterOrByte.

In order to be sure that this will work in reverse (when you write a  
bytearray but you search with a char) I also commited  
SocketStreamTest>>testUpToWithByteArray.

Now to test for the case when you search smth that does not exist (either  
as a byte or as a char) we now have testUpToDefaultTimeout, with the proper  
assert.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Labels: Type-Cleanup Milestone-2.0

Comment #6 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: WorkNeeded

Comment #7 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

can not merge  slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: FixReviewNeeded

Comment #8 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

Name:  
SLICE-Issue-2847-SocketStream-not-robuts-against-integer-NickPapoulias.1
Author: NickPapoulias
Time: 2 November 2012, 5:09:39.046 pm
UUID: b1c803db-4ec0-4d65-83d3-109f08e09eb1
Ancestors:
Dependencies: NetworkTests-NickPapoulias.78, Network-Kernel-NickPapoulias.73

re-commiting smth went wrong with the caching


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
In reply to this post by pharo
Updates:
        Status: MonkeyIsChecking

Comment #10 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847#c10

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: WorkNeeded

Comment #11 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847#c11

Monkey went bananas:
--------------------
Error while loading SLICE-Issue-2847--------NickPapoulias.1 from  
http://ss3.gemstone.com/ss/PharoInbox:
        MessageNotUnderstood: receiver of "dependencies" is nil
  1: UndefinedObject(Object)>>doesNotUnderstand: #dependencies
  2: MCVersionMerger>>addVersion:
  3: [:ea |
        | dep |
        dep := ea resolve.
                (records
                                anySatisfy: [:r | r version = dep])
                        ifFalse: [self addVersion: dep]] in MCVersionMerger>>addVersion:
  4: [:each |
        | newLabel |
        (count = 0
                                or: [count + 1 = size
                                                or: [(Time millisecondsSince: lastUpdate)
                                                                >= msecs]])
                        ifTrue: [bar current: count.
                                oldLabel = (newLabel := (labelBlock cull: each)
                                                                        ifNil: [oldLabel])
                                        ifFalse: [ProgressNotification signal: '' extra: (oldLabel :=  
newLabel)].
                                lastUpdate := Time millisecondClockValue].
                aBlock value: each.
                count := count + 1] in [:bar |
        labelBlock := aStringOrBlock isString
                                        ifTrue: [bar label: aStringOrBlock.
                                                [:item | aStringOrBlock]]
                                        ifFalse: [aStringOrBlock].
                self
                        do: [:each |
                                | newLabel |
                                (count = 0
                                                or: [count + 1 = size
                                                                or: [(Time millisecondsSince: lastUpdate)
                                                                                >= msecs]])
                                        ifTrue: [bar current: count.
                                                oldLabel = (newLabel := (labelBlock cull: each)
                                                                                        ifNil: [oldLabel])
                                                        ifFalse: [ProgressNotification signal: '' extra: (oldLabel :=  
newLabel)].
                                                lastUpdate := Time millisecondClockValue].
                                aBlock value: each.
                                count := count + 1]] in Array(Collection)>>do:displayingProgress:every:
  5: Array(SequenceableCollection)>>do:
  6: [:bar |
        labelBlock := aStringOrBlock isString
                                        ifTrue: [bar label: aStringOrBlock.
                                                [:item | aStringOrBlock]]
                                        ifFalse: [aStringOrBlock].
                self
                        do: [:each |
                                | newLabel |
                                (count = 0
                                                or: [count + 1 = size
                                                                or: [(Time millisecondsSince: lastUpdate)
                                                                                >= msecs]])
                                        ifTrue: [bar current: count.
                                                oldLabel = (newLabel := (labelBlock cull: each)
                                                                                        ifNil: [oldLabel])
                                                        ifFalse: [ProgressNotification signal: '' extra: (oldLabel :=  
newLabel)].
                                                lastUpdate := Time millisecondClockValue].
                                aBlock value: each.
                                count := count + 1]] in Array(Collection)>>do:displayingProgress:every:
  7: BlockClosure>>cull:
  8: [result := block cull: self] in [self prepareForRunning.
                [result := block cull: self]
                        on: JobNotification
                        do: [:notification | notification handle: self]] in Job>>run
  9: BlockClosure>>on:do:
10: [self prepareForRunning.
                [result := block cull: self]
                        on: JobNotification
                        do: [:notification | notification handle: self]] in Job>>run
        ...
----------------------------------------------------------
Loaded Source: SLICE-Issue-2847--------NickPapoulias.1 from  
http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20382-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.166 uuid:  
5773fcb9-2982-4507-8a9e-4308ec33731e Nov  6 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.166 uuid:  
5773fcb9-2982-4507-8a9e-4308ec33731e Nov  6 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
a7bf128cd3b9389e77ea0cdec9a515282926a483 Date: 2012-11-02 14:17:44 +0100  
By: Esteban Lorenzano <[hidden email]> Jenkins build #136


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: HumanReviewNeeded

Comment #12 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 2847 in pharo: SocketStream not robuts against integer

pharo
Updates:
        Status: WorkNeeded

Comment #13 on issue 2847 by [hidden email]: SocketStream not robuts  
against integer
http://code.google.com/p/pharo/issues/detail?id=2847

after merging this, running all tests of SocketStreamTest does not  
terminate.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker