Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo

Comment #16 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

i saved a fix(SLICE-Issue-3088-MNU-TextwithBlanksTrimmed) to PharoInbox.
could someone verify it, please? because it's my first fix.
thanks



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo
Updates:
        Status: FixProposed

Comment #17 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo

Comment #18 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

Thanks. Did you sign the license agreement?
If not please print it, scan it if you want and send it to us.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo

Comment #19 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

yes, i did. i will send it to you again


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo

Comment #20 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

The problem is  not that references with "stringVersion" being a Text are  
created.

The *read* problem is in MethodReference>>#asStringOrText:


asStringOrText
        | text |
        self actualClass ifNil: [ ^stringVersion ].
        text := Text fromString: self stringVersion,' {',self category  
asString,'} '.
        self isLocalSelector ifFalse: [ text addAttribute: TextEmphasis italic ].
        ^ text

#fromString: does not check if it gets a string or a text, leading to a  
broken Text instance.
In addtion, the text looses the formatting (in the protocol browser, it  
uses a text to make
some prints BOLD).

So the change is this:


asStringOrText
        | text |
        self actualClass ifNil: [ ^stringVersion ].
        text := (self stringVersion,' {',self category asString,'} ') asText.
        self isLocalSelector ifFalse: [ text addAttribute: TextEmphasis italic ].
        ^ text

because #asText just keeps a text being a text and converts a string to a  
text... the nice thing is
that this fixes not only the DNU but enables bold printing of the local  
methods in the protocolbrowser again,
too.

Fix attached.


Attachments:
        MethodReference-asStringOrText.st  403 bytes


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo
Updates:
        Status: FixToInclude

Comment #21 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

verified your fix in

Pharo image: Pharo1.3a#13171
Virtual machine used: Squeak4.1 of 17 April 2010 [latest update: #9957]
Platform Name: unix
Class browser used (if applicable): Browser


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3088 in pharo: MNU Text>>withBlanksTrimmed

pharo
Updates:
        Status: Closed

Comment #22 on issue 3088 by [hidden email]: MNU  
Text>>withBlanksTrimmed
http://code.google.com/p/pharo/issues/detail?id=3088

in 13172


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker