Re: Issue 3185 in pharo: BitmapStreamTests have errors

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3185 in pharo: BitmapStreamTests have errors

pharo
Updates:
        Cc: alexandre.bergel

Comment #2 on issue 3185 by guillermopolito: BitmapStreamTests have errors
http://code.google.com/p/pharo/issues/detail?id=3185

As we noticed, here are two problems:
1) SmartStreamRef>>nextPut: has already an instance variable that (as we  
supose) was removed while removing UniClasses)
2) After removing the line using that variable, we had another issue:
   The test is Saving an ImageSegment in a file, and then it is loading it  
using

(FileDirectory default readOnlyFileNamed: externalSegmentFilename)  
fileInObjectAndCode

which throws an Invalid UTF8 input detected (because it is assuming the  
file as a text file).



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3185 in pharo: BitmapStreamTests have errors

pharo

Comment #3 on issue 3185 by stephane.ducasse: BitmapStreamTests have errors
http://code.google.com/p/pharo/issues/detail?id=3185

1) SmartStreamRef>>nextPut: has already an instance variable that (as we  
supose) was removed while removing UniClasses)

which instance variable?



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3185 in pharo: BitmapStreamTests have errors

pharo

Comment #4 on issue 3185 by stephane.ducasse: BitmapStreamTests have errors
http://code.google.com/p/pharo/issues/detail?id=3185

what a fucking bad bad bad code.
In fact in the middle of uniclass handling there was some code needed for  
other and normal behavior.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3185 in pharo: BitmapStreamTests have errors

pharo
Updates:
        Status: Fixed

Comment #5 on issue 3185 by stephane.ducasse: BitmapStreamTests have errors
http://code.google.com/p/pharo/issues/detail?id=3185

(No comment was entered for this change.)

Attachments:
        SmartRefStream-nextPut.st  1.7 KB
        SmartRefStream-appendClassDefinitions.st  849 bytes


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3185 in pharo: BitmapStreamTests have errors

pharo
Updates:
        Status: Closed

Comment #6 on issue 3185 by stephane.ducasse: BitmapStreamTests have errors
http://code.google.com/p/pharo/issues/detail?id=3185

in 12236