Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

pharo

Comment #1 on issue 3271 by nicolas.cellier.aka.nice: r isLiteralSymbol:  
#<= is broken
http://code.google.com/p/pharo/issues/detail?id=3271

Also works in Squeak


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

pharo
Updates:
        Status: Fixed

Comment #2 on issue 3271 by guillermopolito: r isLiteralSymbol: #<= is  
broken
http://code.google.com/p/pharo/issues/detail?id=3271

The part of the method that seems to be working in CUIS is commented in  
pharo:

"[^(2 to: i) allSatisfy: [:j |
                        ascii := (aSymbol at: j) asciiValue.
                        (TypeTable at: ascii ifAbsent: []) == #xBinary]]."

I discommented it, and Compiler tests ran ok.  I attach the changeset with  
the fix!

Attachments:
        isLiteralSymbol.1.cs  1.2 KB


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

pharo

Comment #3 on issue 3271 by stephane.ducasse: r isLiteralSymbol: #<= is  
broken
http://code.google.com/p/pharo/issues/detail?id=3271

Tx guillermo.
Did you run all the tests?


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

Guillermo Polito
I just ran Compiler tests.

On Thu, Dec 23, 2010 at 7:20 AM, <[hidden email]> wrote:

Comment #3 on issue 3271 by stephane.ducasse: r isLiteralSymbol: #<= is broken Tx guillermo.
Did you run all the tests?



Reply | Threaded
Open this post in threaded view
|

Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

pharo
In reply to this post by pharo

Comment #4 on issue 3271 by marcus.denker: r isLiteralSymbol: #<= is broken
http://code.google.com/p/pharo/issues/detail?id=3271

I recompiled the image and ran all tests. looks good.


Reply | Threaded
Open this post in threaded view
|

Re: Issue 3271 in pharo: r isLiteralSymbol: #<= is broken

pharo
Updates:
        Status: Closed

Comment #5 on issue 3271 by marcus.denker: r isLiteralSymbol: #<= is broken
http://code.google.com/p/pharo/issues/detail?id=3271

12287