Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

pharo
Updates:
        Status: FixReviewNeeded

Comment #6 on issue 3466 by [hidden email]: Display the leading zero  
while printing the hexadecimal version of a Character
http://code.google.com/p/pharo/issues/detail?id=3466

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

pharo

Comment #7 on issue 3466 by [hidden email]: Display the leading zero  
while printing the hexadecimal version of a Character
http://code.google.com/p/pharo/issues/detail?id=3466

Slice with Fix+tests added to the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

pharo
Updates:
        Status: FixToInclude

Comment #8 on issue 3466 by [hidden email]: Display the leading zero  
while printing the hexadecimal version of a Character
http://code.google.com/p/pharo/issues/detail?id=3466

review done, that good.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

pharo
Updates:
        Status: Workneeded

Comment #9 on issue 3466 by [hidden email]: Display the leading zero  
while printing the hexadecimal version of a Character
http://code.google.com/p/pharo/issues/detail?id=3466

If we're doing this, it's best to be consistent independent of whether it's  
an ascii or unicode character.

AFAICT,
self assert: (Character value:256) printStringHex = '0100'
would not pass.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

pharo

Comment #10 on issue 3466 by [hidden email]: Display the leading zero  
while printing the hexadecimal version of a Character
http://code.google.com/p/pharo/issues/detail?id=3466

String asHex does not make much sense anyways...
Thought the current implementation is clearly broken, if it were to be  
implemented using Character >> #printStringHex, it would inevitably lead to  
more subtle breakage when used with WideStrings.




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3466 in pharo: Display the leading zero while printing the hexadecimal version of a Character

pharo

Comment #11 on issue 3466 by [hidden email]: Display the leading  
zero while printing the hexadecimal version of a Character
http://code.google.com/p/pharo/issues/detail?id=3466

Hi henrik so should I or not integrate this change.
What is the next action?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker