Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Status: Accepted
        Labels: Type-Cleanup

Comment #1 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

At least they should all be the same


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Labels: Difficulty-Easy

Comment #2 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Status: FixReviewNeeded
        Owner: [hidden email]

Comment #3 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

Fix in inbox:  
SLICE-Issue-3621-The-S-in-fullscreen-should-not-be-capitalized-SeanDeNigris.1

Changes made by the following doIt:
fullscreenMethods := SystemNavigation default allMethodsSelect: [ :m | m  
selector includesSubString: 'ullScreen' ].
fullscreenMethods do: [ :e | | refactoring |
        refactoring := RenameMethodRefactoring
                renameMethod: e selector
                in: e methodClass
                to: (e selector copyReplaceAll: 'ullScreen' with: 'ullscreen') asSymbol
                permutation: (1 to: e selector numArgs).
        [ refactoring execute ] on: RBRefactoringError do: [ :error |
                "Will fail if selector has already been renamed in another class. Just  
ignore it" ] ].


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Status: FixToInclude
        Labels: Milestone-1.3 Milestone-1.4

Comment #4 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

The fix is ok for me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Status: Workneeded
        Labels: -Milestone-1.3 -Milestone-1.4

Comment #5 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

Some comments need to be changed accordingly.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo

Comment #6 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

pay attention work needed means that it is not in our direct radar.
May be you should tag it as fixToINclude so that you push changes at us.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Status: FixToInclude

Comment #7 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Labels: Milestone-1.4

Comment #8 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo

Comment #9 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

SLICE-Issue-3621-The-S-in-fullscreen-should-not-be-capitalized-SeanDeNigris.3

Updated all references I could find (including comments) via:
   SystemNavigation default browseMethodsWithSourceString: 'ullScreen'


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo

Comment #10 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

Ok works for me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 3621 in pharo: The S in fullscreen should not be capitalized

pharo
Updates:
        Status: Integrated

Comment #11 on issue 3621 by [hidden email]: The S in fullscreen  
should not be capitalized
http://code.google.com/p/pharo/issues/detail?id=3621

in 14240


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker