Re: Issue 3789 in pharo: convert MenuMorph reference to invoke UIManager

Updates:
        Cc: [hidden email]

Comment #6 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

I need help on this one :)




_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

Here are the easy ones.

I don't know how you realized that I'll be working this afternoon :P

Attachments:
        MenuMorph.1.cs  32.3 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

The ones wich used to use #entitled:

Attachments:
        MenuMorph part 2.1.cs  6.0 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

The ones who used #fromArray:

Attachments:
        MenuMorph part 3.1.cs  5.1 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

Replaced some

UIManager default menuClass new defaultTarget: self

by

UIManager default newMenuIn: self for: self

Attachments:
        MenuMorph part 4.1.cs  3.3 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #11 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

now MorphicUIManager>>menuClass has no senders ;)

I think we should do one of the following:
- remove it since MorphicUIManager delegates the menu creation to the theme
- let the theme ask for the menuClass to the UIManager


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #12 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

What lasts:

some #isKindOf: MenuMorph

some Toolbuilder references

and

UIThemeStandardSqueak>>menuPinForm
        "Answer the form to use for the pin button of a menu."

        ^MenuMorph pushPinImage

That shows that pushPinImage should be somewhere else maybe ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixProposed

Comment #13 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Milestone-1.3

Comment #14 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

Thanks guile. I will integrate your work now.
I was fixing my house today.
Yes for the pushinUImage.....
but one step at a time.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

Thanks guile. I will integrate your work now.
I was fixing my house today.
Yes for the pushinUImage.....
but one step at a time.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Closed

Comment #16 on issue 3789 by [hidden email]: convert MenuMorph  
reference to invoke UIManager
http://code.google.com/p/pharo/issues/detail?id=3789

in 13228


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker