Comment #4 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 Next step: someone with a russian keyboard should verify that this fix is good _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: -Milestone-1.3 Comment #5 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 Ok, this seems to be not important for 1.3 considering that I am the only person who reacted *but* I can not do anything. So this is not actionable for 1.3 release. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #6 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 It is bad that no other russians check this issue. But I think root of this problem in wrong keystrokes handling logic in text editors. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #7 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 Well, yes and no. It is perfectly reasonable to assume arrow up to always be in the single-byte ascii keyValue. It is however also perfectly reasonable to assume keyValue will not contain garbage values for Unicode input, which it does on Windows. So either one could change uses of keyValue like proposed here, which would require different patches for 1.2 and 1.3 based on some refactorings made in TextEditor, or one could hack in consistency in the event processor where KeyboardEvents are generated, no always return 0 as keyValue when charCode is outside single-byte range. There may still be trouble as the case of ctrl-character presses are different for charCode and keyValue (at least on Windows), but that's another matter. Find modified method attached for testing, the relevant part is: "Adjustments to provide consistent key value data for different VM's: - charCode always contains unicode code point. - keyValue contains 0 if input is outside legacy range" "If there is no unicode data in the event, assume keyValue contains a correct (<256) Unicode codepoint, and use that" (charCode isNil or: [charCode = 0]) ifTrue: [charCode := keyValue]. "If charCode is not single-byte, we definately have Unicode input. Nil keyValue to avoid garbage values from som VMs." charCode > 255 ifTrue: [keyValue := 0]. Attachments: HandMorph-generateKeyboardEvent.st 2.4 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #8 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 What remains is that it should be tested on Mac/Unix not to cause regressions with Russian and/or other keyboard layouts, on Windows the behaviour is as described in comments, and leads to desired result. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #9 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 I test it on my Windows 7 for Pharo1.2.1 and latest build 1.3. All work good _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #10 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 can we integrate this? Or its too late for 1.3? I tried russian on macs, all chars can be entered correctly. Now what keystrokes may be affected by this change (in addition to fix of russian layout?) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: Milestone-1.4 Comment #11 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 I would prefer to keep it for 1.4. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #12 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 "what keystrokes may be affected by this change?" The ones highlighted in the relevant part. Most important ones: - charCode actually contains the unicode code point if not nil/zero - if it is, the correct ascii/latin1 keycode can be found in keyValue. - if outside 1byte char range, charCode will never be zero. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Closed Comment #13 on issue 3916 by [hidden email]: Can't input some Russian characters at text editors http://code.google.com/p/pharo/issues/detail?id=3916 in 14039 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |