Re: Issue 3974 in pharo: [RPackage] rpackage do not update when adding a category

Updates:
        Labels: Milestone-1.3

Comment #1 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: Type-Bug

Comment #2 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #3 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

Hmm...

addCategory: catString before: nextCategory
        | oldCategories |
        oldCategories := self categories copy.
        SystemChangeNotifier uniqueInstance doSilently: [
                super addCategory: catString before: nextCategory].
        self notifyOfChangedCategoriesFrom: oldCategories to: self categories.


The notifyOfChangedCategoriesFrom:to: actually does have a call to emit an  
event:

notifyOfChangedCategoriesFrom: oldCollectionOrNil to: newCollectionOrNil
        (self hasSubject and: [oldCollectionOrNil ~= newCollectionOrNil])
                ifTrue: [SystemChangeNotifier uniqueInstance classReorganized: self  
subject].



maybe it is wrong in some cases? Not that I understand this too much...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.3 Milestone-1.4

Comment #4 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Owner: ---
        Cc: [hidden email]

Comment #5 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

cyrille did you address it?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #6 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

I was talking about 'System' categories. I think the method involved to add  
a system category is:

SystemOrganizer >> addCategory: catString before: nextCategory
        "Add a new category named heading.
        If default category exists and is empty, remove it.
        If nextCategory is nil, then add the new one at the end,
        otherwise, insert it before nextCategory."
        | index newCategory |
        newCategory := catString asSymbol.
        (categoryArray indexOf: newCategory) > 0
                ifTrue: [^self]. "heading already exists, so done"
        index := categoryArray indexOf: nextCategory
                ifAbsent: [categoryArray size + 1].
        categoryArray := categoryArray
                copyReplaceFrom: index
                to: index-1
                with: (Array with: newCategory).
        categoryStops := categoryStops
                copyReplaceFrom: index
                to: index-1
                with: (Array with: (index = 1
                                ifTrue: [0]
                                ifFalse: [categoryStops at: index-1])).
        "remove empty default category"
        (newCategory ~= Default
                        and: [(self listAtCategoryNamed: Default) isEmpty])
                ifTrue: [self removeCategory: Default]



And it seems that there is no notifications


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: -[hidden email]
        Labels: -Milestone-1.4

Comment #7 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Invalid

Comment #8 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974

I think this is fixed


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: MigratedToFogBugz

Comment #9 on issue 3974 by [hidden email]: [RPackage] rpackage do  
not update when adding a category
http://code.google.com/p/pharo/issues/detail?id=3974#c9

Issue migrated to https://pharo.fogbugz.com/f/cases/4021

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker