Comment #2 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 Next Step: Review. Is this problem a problem? Is the Fix good? Will this break everything? Why not? _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #3 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 Yes, this is a problem. No, the fix is not good. - is not a special case, any of the special characters will not end the symbol IF ' after #. The "fix" also allows reading '#abra-cadrabra', which is NOT allowed. If something would break though, it probably already would've been when the method was changed to not use the canonical in Scanner for parsing Symbols in the first place. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Comment Comment #4 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixProposed Comment #5 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 Here come a new cs that fix that (I hope). As I have already said, I DO NOT know the expected behavior, so please, help me writing tests by fixing the SymbolTest>>#expectedBehavior method For now, I have those behaviors: [Symbol readFromString: '#''abc'''] -> #abc. [Symbol readFromString: '#ab-C'] -> #ab. [Symbol readFromString: '#''plop-plip'''] -> #'plop-plip'. [Symbol readFromString: '#abC'] -> #abC. [Symbol readFromString: '#ab@c'] -> #ab Is that right ? Is there other traps ? Attachments: SymbolReadFromStringStrikeBack.1.cs 1.1 KB _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #6 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 So what is the solution? _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #7 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 Like I said, $- is not a special case. #'abra@dabra' is also a valid symbol. In addition, the code does not handle unbalanced quotes. These aren't "pittfalls", this is basic smalltalk syntax. I'd say revert to the old version utilizing Scanner, if for nothing else, then to use a consistent definition of how a Symbol should/can be read. If you really need to decouple it from Compiler, you could (I think) move Scanner to a package both have as dependency. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Comment Comment #8 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 (No comment was entered for this change.) _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: FixToInclude Comment #9 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 Not a comment; I meant revert to the source from 1.2. It's attached here, as I can't find it in versions of the downloadable 1.3 image Attachments: Symbol class-readFrom.st 366 bytes _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #10 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 We really want to have the compiler out of the kernel. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #11 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 Then read the end of comment 7. Copy-pasting code from one package to another, or, in this case I guess you could call it "rewrite it, and add some bugs too", is not a proper way to break dependencies. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #12 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 But we do not want to have Scanner inside the kernel too. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #13 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 I suggest we put this back as it was and look into the issue in the context of Opal. _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Comment #14 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 ok for me. I want to see the bootstrap making progress. Stef _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Status: Closed Comment #15 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022 in 13204 _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Updates:
Labels: MigratedToFogBugz Comment #16 on issue 4022 by [hidden email]: Symbol readFrom: http://code.google.com/p/pharo/issues/detail?id=4022#c16 Issue migrated to https://pharo.fogbugz.com/f/cases/4069 -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings _______________________________________________ Pharo-bugtracker mailing list [hidden email] http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker |
Free forum by Nabble | Edit this page |