Re: Issue 5499 in pharo: SequenceableCollection>>#copyReplaceAll:with:asTokens: should be moved to string

Updates:
        Summary: SequenceableCollection>>#copyReplaceAll:with:asTokens:   should  
be moved to string

Comment #2 on issue 5499 by [hidden email]:  
SequenceableCollection>>#copyReplaceAll:with:asTokens:   should be moved to  
string
http://code.google.com/p/pharo/issues/detail?id=5499

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #3 on issue 5499 by [hidden email]:  
SequenceableCollection>>#copyReplaceAll:with:asTokens:   should be moved to  
string
http://code.google.com/p/pharo/issues/detail?id=5499

The validation is not in the last version of the image, he.


I moved that method to String, and implemented in text things like:

copyReplaceAll: oldSubstring with: newSubstring asTokens: asTokens.
        ^(self string copyReplaceAll: oldSubstring with: newSubstring asTokens:  
asTokens) asText.

I removed the Trait testing this from every sequenceable collection test  
and keep it only in string and symbol tests.


Now, is it ok to expect this replacement only for strings?

Attachments:
        copyReplaceAll move.2.cs  51.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-1.4 Milestone-1.5

Comment #5 on issue 5499 by [hidden email]:  
SequenceableCollection>>#copyReplaceAll:with:asTokens:   should be moved to  
string
http://code.google.com/p/pharo/issues/detail?id=5499

I do not get at all the purpose of this method and especially the purpose  
of asTokens parameter.
I'm totally confused. I tried the examples but nothing is clear.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker