Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Summary: Julian Dates wrong before 15 Nov 1582
        Status: WorkNeeded
        Labels: Target-Date

Comment #2 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

extracted the fix, tests missing

Attachments:
        DateAndTime-dayMonthYearDo.st  1.4 KB


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Labels: -Target-Date Target-Chronology

Comment #3 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Status: FixReviewNeeded

Comment #4 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Labels: Milestone-2.0

Comment #5 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Status: WorkNeeded

Comment #7 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162#c7

Monkey went bananas:
--------------------
Error while loading "DateAndTime-dayMonthYearDo.st" from Comment #2:
        MessageNotUnderstood: ReadStream>>fileIn
  1: ReadStream(Object)>>doesNotUnderstand: #fileIn
  2: [attachment contents asString readStream fileIn] in [:attachment |  
[attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e |
                                self addError: e forFile: attachment description.
                                self debug: e]] in UlysseTheMonkey>>loadChangeSet
  3: BlockClosure>>on:do:
  4: [:attachment | [attachment contents asString readStream fileIn]
                        on: Error
                        do: [:e |
                                self addError: e forFile: attachment description.
                                self debug: e]] in UlysseTheMonkey>>loadChangeSet
  5: Array(SequenceableCollection)>>do:
  6: UlysseTheMonkey>>loadChangeSet
  7: [self loadChangeSet] in UlysseTheMonkey>>loadAndTestChangeSet
  8: [loadStopwatch reset activate.
                aBlock value.
                loadStopwatch suspend.
                testResult := self runTests.
                self removeFalseErrors] in UlysseTheMonkey>>testChangeImpact:
  9: BlockClosure>>on:do:
10: UlysseTheMonkey>>testChangeImpact:
        ...
----------------------------------------------------------
Loaded Source: "DateAndTime-dayMonthYearDo.st" from Comment #2
Tested using Pharo-2.0-20339-a on CoInterpreter  
VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct  2 2012
StackToRegisterMappingCogit VMMaker-oscog-EstebanLorenzano.164 uuid:  
d77dee73-00f5-4d00-847b-00646b08329d Oct  2 2012
git://gitorious.org/cogvm/blessed.git Commit:  
bfc9fe2c4abcd2972c8bd9eac1c77f9baaf23e8a Date: 2012-09-25 13:34:47 +0200  
By: Esteban Lorenzano <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Status: HumanReviewNeeded

Comment #8 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo

Comment #9 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

Provided the algorithm was coded correctly, and all tests remain green,  
this seems OK.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Status: Integrated

Comment #10 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

in 2.0 342


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Status: WorkNeeded

Comment #11 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

the var jdn was renamed to julianDayNumber in Pharo.

So adding this breaks everything.





_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo

Comment #12 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

What needs to be done
  -> change the var name in the text file
-> load the code
-> run tests
-> save as a slice


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo

Comment #13 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

OK, I'll have a look and produce a proper slice, if all goes well.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo

Comment #14 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

Name:  
SLICE-Issue-6162-Julian-Dates-wrong-before-15-Nov-1582--SvenVanCaekenberghe.1
Author: SvenVanCaekenberghe
Time: 16 October 2012, 10:51:54.334 am
UUID: df74d5f2-f38f-470f-b11d-8ea3a4a32d54
Ancestors:
Dependencies: Kernel-SvenVanCaekenberghe.1213

Try to fix julian date -> gregorian calendar conversions for dates before  
15 Nov 1582.

This is still incomplete as the other part, gregorian calendar -> julian  
date does not yet make a special case for dates before 15 Nov 1582.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo

Comment #15 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

We still need the equivalent/inverse change in

DateAndTime class>>#year:month:day:hour:minute:second:nanoSecond:offset:

Has anyone found a description somewhere describing how to do this ?

CURRENT STATE: incomplete, cannot be integrated.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6162 in pharo: Julian Dates wrong before 15 Nov 1582

pharo
Updates:
        Labels: -Milestone-2.0

Comment #16 on issue 6162 by [hidden email]: Julian Dates wrong  
before 15 Nov 1582
http://code.google.com/p/pharo/issues/detail?id=6162

not for 2.0


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker