Re: Issue 6477 in pharo: Remove SystemChangeNotifier 3 - Cleaning step 1

Updates:
        Summary: Remove SystemChangeNotifier 3 - Cleaning step 1
        Status: FixReviewNeeded

Comment #6 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477

- MCWorkingCopy>>#initialize should do an #unsubscribe:, not just remove  
the unsubscription
Why? There is no SystemChangeNotifier anymore and no need to unsubscribe  
working copies from SystemAnnouncer since announcement registration is done  
on the class side.

- I'm not sure we should change the code in ScriptLoader... Maybe move it  
to the form "Smalltalk at:"
I used code rewriting so I didn't pay attention about where it was applied.  
But anyway we already did Friday: we replaced SystemChangeNotifier with  
SystemAnnouncer everywhere, including in the Scripltloader methods. Should  
I revert that too?


I corrected the rest.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Type-Feature Type-Cleanup

Comment #7 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477

-- MCWorkingCopy>>#initialize should do an #unsubscribe:, not just remove  
the unsubscription
-Why? There is no SystemChangeNotifier anymore and no need to unsubscribe  
working copies from SystemAnnouncer since announcement registration is done  
on the class side.

Yeap, you're right.  Havent noticed that.

-- I'm not sure we should change the code in ScriptLoader... Maybe move it  
to the form "Smalltalk at:"
-I used code rewriting so I didn't pay attention about where it was  
applied. But anyway we already did Friday: we replaced SystemChangeNotifier  
with SystemAnnouncer everywhere, including in the Scripltloader methods.  
Should I revert that too?

Hmm, not sure about the past changes... The thing is that modifying it we  
are maybe breaking the update mechanism for older versions...
Esteban? have a word on this one?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: WorkNeeded

Comment #10 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477#c10

Monkey went bananas:
--------------------
Error while loading  
SLICE-Issue-6477-Remove-SystemChangeNotifier-3---ChangesLog-use-announcements-CamilleTeruel.3  
from http://ss3.gemstone.com/ss/PharoInbox:
        MCMergeOrLoadWarning: You are about to load new versions of the following  
packages
that have unsaved changes in the image:

   Monticello
   Monticello
   Tests
   Tests

If you continue, you will lose these changes:
  1: MCVersionLoader>>warnAboutLosingChangesTo:ifCancel:ifMerge:
  2: MCVersionLoader>>checkForModificationsIfCancel:ifMerge:
  3: MCVersionLoader>>loadWithNameLike:
  4: MCVersionLoader>>load
  5: GoferLoad>>execute
  6: Gofer>>execute:do:
  7: Gofer>>execute:
  8: Gofer>>load
  9: GoferResolvedReference>>load
10: [self slice load] in UlysseTheMonkey>>loadSlice
        ...Test Results:
-------------
Passed: 7140
        CollectionsTests-Arrayed (547)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (906)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (596)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1951)
        CollectionsTests-Weak (739)
        CompilerTests (179)
        KernelTests-Chronology (583)
        KernelTests-Classes (65)
        KernelTests-Exception (2)
        KernelTests-Methods (178)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (31)
        Nautilus-Tests (8)
        RPackage-SystemIntegration (73)
        RPackage-Tests (83)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        Tests-Bugs (25)
        Tests-CodeImport (9)
        Tests-Compression (10)
        Tests-Digital Signatures (8)
        Tests-Exceptions (28)
        Tests-Files (21)
        Tests-Finalization (1)
        Tests-Monticello (122)
        Tests-Multilingual (3)
        Tests-Object Events (24)
        Tests-ObjectsAsMethods (3)
        Tests-PackageInfo (2)
        Tests-Polymorph-Widgets (10)
        Tests-Release (2)
        Tests-ScriptLoader (4)
        Tests-System (271)
        Tests-System-CommandLine (14)
        Tests-SystemChangeNotification (1)
        Tests-SystemHistory (14)
        Tests-TextEditors (3)
        Tests-Traits (58)
        Tests-Traits-MOP (3)
        Tests-VM (10)


Failures: 1
        ReleaseTest>>#testObsoleteClasses

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-6477-Remove-SystemChangeNotifier-3---ChangesLog-use-announcements-CamilleTeruel.3  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20236-a on CoInterpreter  
VMMaker-oscog-IgorStasenko.162 uuid: e4554f9a-cc90-4826-a807-ac282b782fe4  
Jul 26 2012
StackToRegisterMappingCogit VMMaker-oscog-IgorStasenko.162 uuid:  
e4554f9a-cc90-4826-a807-ac282b782fe4 Jul 26 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
aeb0705cde4b8fc57cb262dc051c5ee6dfa72a14 Date: 2012-07-26 16:38:48 +0200  
By: Igor Stasenko <[hidden email]>


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: HumanReviewNeeded

Comment #11 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #12 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477

I changed a bit to keep the ScriptLoader working even if you try to  
reconstruct from previous versions with a newer ScriptLoader (a really  
weird situation, cannot think how that can happen)... all the other looks  
ok.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #13 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleaning step 1
http://code.google.com/p/pharo/issues/detail?id=6477

in 20239


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker