Re: Issue 6477 in pharo: Remove SystemChangeNotifier 3 - Cleansings step 1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 6477 in pharo: Remove SystemChangeNotifier 3 - Cleansings step 1

pharo
Updates:
        Summary: Remove SystemChangeNotifier 3 - Cleansings step 1

Comment #5 on issue 6477 by [hidden email]: Remove  
SystemChangeNotifier 3 - Cleansings step 1
http://code.google.com/p/pharo/issues/detail?id=6477

Review Review:

- ChangeSet>>#event: is not needed any more
- SmalltalkImage>>#startUp should be fixed if you put the subscriptions in  
the ChangesLog
- MCWorkingCopy>>#initialize should do an #unsubscribe:, not just remove  
the unsubscription
- in MethodModified
     there are still references to the event variable, though it is never  
assigned.
     #itemOldProtocol is removed, but used by MCPackageManager  
class>>#methodMoved:
- I'm not sure we should change the code in ScriptLoader... Maybe move it  
to the form "Smalltalk at:"

For the rest it looks ok to me.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker