Re: Issue 6618 in pharo: RGMethodDefintion isFromTrait / Ring Trait interaction

Updates:
        Summary: RGMethodDefintion isFromTrait / Ring Trait interaction

Comment #5 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Cc: [hidden email]

Comment #6 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #7 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

I quickly saw RGMethodDefinition>>isFromTrait and RGMethodDefinition>>origin
Tomorrow I will see this in more detail, we have to be careful because as  
is now it only works for active methods (ie. when reading from the compiled  
method)... But Ring is not only for that.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #8 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

Yeah I know :/.. I just made sure I patched enough so the tools work with  
the in-image data. But it's not complete nor fully correct ;)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #9 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

Cami, CompiledMethod>>origin is only retuning the class/trait no the  
package in the case of an extension...
You are talking about this before... Is that needed? in such a case the  
change should also happens there first, but I don't know the impact...
For now I will properly introduce origin in Ring but just returning  
class/trait.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #10 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

I added CompiledMethod>>#origin to fix a bug with Trait recompilations.
So I guess for now that is fine.

However I think that package extensions should be treated the same way, but  
that is not urgent. Though we already have quite some issues with incorrect  
mapping of extension methods in Monticello, so it might make sense to have  
an explicit notion of where a method came from.

It would be nice if all the tools, except for the very core of the compiler  
would work with the Ring objects instead of the low-level instances like  
CompiledMethod and Class.


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Labels: -Milestone-2.0 Milestone-3.0

Comment #11 on issue 6618 by [hidden email]: RGMethodDefintion  
isFromTrait / Ring Trait interaction
http://code.google.com/p/pharo/issues/detail?id=6618

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker