Updates:
Labels: Milestone-1.3 Milestone-1.4
Comment #20 on issue 709 by
[hidden email]: Debugger highlight bug
http://code.google.com/p/pharo/issues/detail?id=709transformToDo: encoder
" var := rcvr. L1: [var <= arg1] Bfp(L2) [block body. var := var + inc]
Jmp(L1) L2: "
| limit increment block initStmt test incStmt limitInit blockVar myRange
blockRange limitIsAssignedTo |
"First check for valid arguments"
((arguments last isMemberOf: BlockNode)
and: [arguments last numberOfArguments = 1
and: [arguments last firstArgument isVariableReference "As with debugger
remote vars"]]) ifFalse:
[^false].
arguments size = 3
ifTrue: [increment := arguments at: 2.
(increment isConstantNumber
and: [increment literalValue ~= 0]) ifFalse: [^false]]
ifFalse: [increment := encoder encodeLiteral: 1].
(limit := arguments at: 1) isVariableReference ifTrue:
[limitIsAssignedTo := false.
arguments last nodesDo:
[:node|
(node isAssignmentNode and: [node variable = limit]) ifTrue:
[limitIsAssignedTo := true]].
limitIsAssignedTo ifTrue:
[^false]].
arguments size < 3 ifTrue: "transform to full form"
[selector := SelectorNode new key: #to:by:do: code: #macro].
"Now generate auxiliary structures"
myRange := encoder rawSourceRanges at: self ifAbsent: [1 to: 0].
block := arguments last.
blockRange := encoder rawSourceRanges at: block ifAbsent: [1 to: 0].
blockVar := block firstArgument.
initStmt := AssignmentNode new variable: blockVar value: receiver.
limit isVariableReference | limit isConstantNumber
ifTrue: [limitInit := nil]
ifFalse: "Need to store limit in a var"
[limit := encoder bindBlockArg: blockVar key, 'LimiT' within: block.
limit scope: -2. "Already done parsing block; flag so it won't print"
block addArgument: limit.
limitInit := AssignmentNode new
variable: limit
value: arguments first].
test := MessageNode new
receiver: blockVar
selector: (increment key > 0 ifTrue:
[#<=] ifFalse: [#>=])
arguments: (Array with: limit)
precedence: precedence from: encoder
sourceRange: (myRange first to: blockRange
last).
incStmt := AssignmentNode new
variable: blockVar
value: (MessageNode new
receiver: blockVar selector: #+
arguments: (Array with: increment)
precedence: precedence from: encoder)
from: encoder
sourceRange: (myRange last to: myRange last).
arguments := (Array with: limit with: increment with: block),
(Array with: initStmt with: test with: incStmt with: limitInit).
block noteOptimizedIn: self.
^true
nicolas proposed this fix and it seems to work on my image.
_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Locked
