Re: Issue 7090 in pharo: Should Float>>#printOn:base: use the slower exact printing?

Updates:
        Summary: Should Float>>#printOn:base: use the slower exact printing?
        Status: WorkNeeded

Comment #14 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090

Looks good, but a few questions:
- I've gotten burned relying on #initialize for class-side instVars before;  
maybe lazy initialization would be better?
- how about an intention revealing name for absPrintOn: stream base: like  
absPrintFastOn: stream base:
- I think FastFloatPrintPolicy might capture the idea better

Sven, what do you think?


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #15 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090

Thanks for having a look, Sean.

I am not (directly) relying on a class side initialize (it is  
FloatPrintPolicy>>#initialize).
Indirectly, ProcessSpecificVariable class>>#soleInstance is called, but  
that is lazy.

About the naming, I think exact/inexact are more intention revealing, since  
that describes what they do, being slow/fast is a (potentionally temporary)  
consequence.

I did indeed think about renaming Float>>#absPrintOn:base: to  
Float>>#absInexactPrintOn:base: but that sounded so negative, so I decided  
against it ;-)

I guess it could be done, a test would be nice too, probably...


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixReviewNeeded

Comment #16 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090

Name:  
SLICE-Issue-7090-Should-FloatgtgtprintOnbase-use-the-slower-exact-printing--SvenVanCaekenberghe.2
Author: SvenVanCaekenberghe
Time: 8 February 2013, 3:58:06.212 pm
UUID: cbcbf261-435c-4728-94d7-b3ba24594870
Ancestors:  
SLICE-Issue-7090-Should-FloatgtgtprintOnbase-use-the-slower-exact-printing--SvenVanCaekenberghe.1
Dependencies: Kernel-SvenVanCaekenberghe.1304,  
KernelTests-SvenVanCaekenberghe.469

introduction of FloatPrintPolicy, a dynamic variable to control how  
Float>>#printOn:base: works;
ExactFloatPrintPolicy double dispatches to Float>>#absPrintExactlyOn:base:  
for slower but accurate printing [ the current default ];
InexactFloatPrintPolicy double dispatches to Float>>#absPrintOn:base: for  
faster but potentially less accurate printing.

FloatPrintPolicy
        value: InexactFloatPrintPolicy new
        during: [ Float pi printString ]
       
Renamed Float>>#absPrintOn:base: to #absPrintInexactlyOn:base:

Added silly FloatTest>>#testFloatPrintPolicy testing the new code path



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: MonkeyIsChecking

Comment #17 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090#c17

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20529

Comment #18 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090#c18

This Issue has been checked by Ulysse the Monkey
       
7634 tests passed in 00:03:31s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (1186)
        KernelTests-Classes (138)
        KernelTests-Exception (5)
        KernelTests-Methods (359)
        KernelTests-Numbers (554)
        KernelTests-Objects (172)
        KernelTests-Pragmas (6)
        KernelTests-Processes (76)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7090-Should-FloatgtgtprintOnbase-use-the-slower-exact-printing--SvenVanCaekenberghe.2  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20529-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: FixToInclude

Comment #19 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Updates:
        Status: Integrated

Comment #20 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090

in 2.0 530


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker

Comment #21 on issue 7090 by [hidden email]: Should  
Float>>#printOn:base: use the slower exact printing?
http://code.google.com/p/pharo/issues/detail?id=7090

It is probably good to record the following link:

http://marc.info/?l=squeak-dev&m=133545987829071&w=2



_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker