Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Summary: Nautilus' create Package Dialog allows Extension names

Comment #3 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

humm ok looks like I managed to create a package with the name of a an  
extension??
=> changed the title


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo

Comment #4 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

So I think it was caused by actually renaming an existing package (like  
Kernel) to a valid extension name (*System-FileRegistry). naturally this  
causes severe problems


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: FixReviewNeeded

Comment #5 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

I add a validation in the package name.
Now it can't start with a * (and there is a message telling you that it's  
wrong ^^)

Slice in the inbox


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: MonkeyIsChecking

Comment #6 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408#c6

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20513

Comment #7 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408#c7

This Issue has been checked by Ulysse the Monkey
       
6414 tests passed in 00:01:21s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7408-Nautilus-create-Package-Dialog-allows-Extension-names-BenjaminVanRyseghem.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20513-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: MonkeyIsChecking

Comment #8 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408#c8

The Monkey is currently checking this issue. Please don't change it!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: ValidatedByTheMonkey
        Labels: CheckedIn20514

Comment #9 on issue 7408 by [hidden email]: Nautilus' create Package  
Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408#c9

This Issue has been checked by Ulysse the Monkey
       
6414 tests passed in 00:01:27s:
===============================
        CollectionsTests-Arrayed (553)
        CollectionsTests-Atomic (12)
        CollectionsTests-Sequenceable (912)
        CollectionsTests-SplitJoin (27)
        CollectionsTests-Stack (16)
        CollectionsTests-Streams (37)
        CollectionsTests-Strings (611)
        CollectionsTests-Support (12)
        CollectionsTests-Unordered (1954)
        CollectionsTests-Weak (739)
        CompilerTests (181)
        KernelTests-Chronology (593)
        KernelTests-Classes (69)
        KernelTests-Exception (2)
        KernelTests-Methods (179)
        KernelTests-Numbers (276)
        KernelTests-Objects (86)
        KernelTests-Pragmas (3)
        KernelTests-Processes (38)
        SUnit-Core-Extensions (3)
        SUnit-Core-Utilities (3)
        SUnit-Tests-Core (78)
        ToolsTest-Base (2)
        ToolsTest-Debugger (10)
        ToolsTest-Finder (9)
        ToolsTest-Inspector (1)
        ToolsTest-MessageTally (5)
        ToolsTest-PointerFinder (3)

----------------------------------------------------------
Loaded Source:  
SLICE-Issue-7408-Nautilus-create-Package-Dialog-allows-Extension-names-BenjaminVanRyseghem.1  
from http://ss3.gemstone.com/ss/PharoInbox
Tested using Pharo-2.0-20514-a on NBCoInterpreter  
NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
NBCogit NativeBoost-CogPlugin-IgorStasenko.15 uuid:  
44b6b681-38f1-4a9e-b6ee-8769b499576a Nov 27 2012
https://git.gitorious.org/cogvm/blessed.git Commit:  
40ac7e7bdec6fef0e934d2c019b86db996053912 Date: 2012-11-19 18:54:49 +0100  
By: Mariano Martinez Peck <[hidden email]> Jenkins build #146


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo

Comment #10 on issue 7408 by [hidden email]: Nautilus' create  
Package Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

nice!


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: HumanReviewNeeded
        Cc: [hidden email]
        Labels: -CheckedIn20513 -CheckedIn20514

Comment #11 on issue 7408 by [hidden email]: Nautilus' create  
Package Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

The fix looked good, but was not applied to Nautilus...

New fix in inbox:  
SLICE-Issue-7408-Nautilus-create-Package-Dialog-allows-Extension-names-SeanDeNigris.2

- Extend AbstractTool changes from v. 1 to AbstractNautilusUI
- Refactor and clean #renamePackages:; remove from AbstractNautilusUI,  
delegating most of the behavior to AbstractTool


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: FixReviewNeeded

Comment #12 on issue 7408 by [hidden email]: Nautilus' create  
Package Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

I agree with this fix :)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: FixToInclude

Comment #13 on issue 7408 by [hidden email]: Nautilus' create  
Package Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

(No comment was entered for this change.)


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker
Reply | Threaded
Open this post in threaded view
|

Re: Issue 7408 in pharo: Nautilus' create Package Dialog allows Extension names

pharo
Updates:
        Status: Integrated

Comment #14 on issue 7408 by [hidden email]: Nautilus' create  
Package Dialog allows Extension names
http://code.google.com/p/pharo/issues/detail?id=7408

in 2.0 516


_______________________________________________
Pharo-bugtracker mailing list
[hidden email]
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-bugtracker