Re: Loading Seaside results in a number of, Grease related code issues

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Loading Seaside results in a number of, Grease related code issues

Max Leske

> On Thu, May 28, 2020 at 01:01:55PM -0700, tim Rowledge wrote:
>
>> Whilst checking things after installing Seaside and Cryptography I noticed that there are a couple of dangling Undeclareds that lead into some faulty loaded code.
>>
>> 'home' and 'startpc' are referenced in BlockContext>>#tempVarRefs. This is not too much of a problem since there are no senders but since there are also a bunch of methods loaded into the no longer used Context/BlockContext/MethodContext classes it might be an indicator of some updating needed in the Grease package, specifically *grease-squeak5-core. I don't know who looks after this, so if anyone does, please pass it on.
>>

Thanks Tim. Ideally you would open issue reports at https://github.com/SeasideSt/Grease/issues.

You don't mention the Squeak version you're looking at, that would help.

We've just prepared some fixes for Squeak (e.g. #asMutator deprecation) and we could probably get those changes in to the same Release.

>
>
> The grease package is one of those things that we, the Squeak community,
> need to take more responsibility for. If anyone is looking for a worthwhile
> Sunday Squeaker project, this would be a good one.
>
> Dave


That would be great! Just checking Grease / Seaside for obvious issues in Squeak and reporting them to us would be a huge help. We're only 3 (mostly 1) people who do most of the work and we'd love some more help.


Cheers,
Max


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Loading Seaside results in a number of, Grease related code issues

Jakob Reschke
Hi Max,

Is there some CI system for Grease where Squeak could subscribe to the
Squeak-specific results?

Kind regards,
Jakob

Am Fr., 29. Mai 2020 um 07:54 Uhr schrieb Max Leske <[hidden email]>:

>
>
> > On Thu, May 28, 2020 at 01:01:55PM -0700, tim Rowledge wrote:
> >
> >> Whilst checking things after installing Seaside and Cryptography I noticed that there are a couple of dangling Undeclareds that lead into some faulty loaded code.
> >>
> >> 'home' and 'startpc' are referenced in BlockContext>>#tempVarRefs. This is not too much of a problem since there are no senders but since there are also a bunch of methods loaded into the no longer used Context/BlockContext/MethodContext classes it might be an indicator of some updating needed in the Grease package, specifically *grease-squeak5-core. I don't know who looks after this, so if anyone does, please pass it on.
> >>
>
> Thanks Tim. Ideally you would open issue reports at https://github.com/SeasideSt/Grease/issues.
>
> You don't mention the Squeak version you're looking at, that would help.
>
> We've just prepared some fixes for Squeak (e.g. #asMutator deprecation) and we could probably get those changes in to the same Release.
>
> >
> >
> > The grease package is one of those things that we, the Squeak community,
> > need to take more responsibility for. If anyone is looking for a worthwhile
> > Sunday Squeaker project, this would be a good one.
> >
> > Dave
>
>
> That would be great! Just checking Grease / Seaside for obvious issues in Squeak and reporting them to us would be a huge help. We're only 3 (mostly 1) people who do most of the work and we'd love some more help.
>
>
> Cheers,
> Max

Reply | Threaded
Open this post in threaded view
|

Re: Loading Seaside results in a number of, Grease related code issues

Max Leske
Hi Jakob,

We use Travis to build Seaside and Grease: https://travis-ci.org/SeasideSt/Seaside/branches

Cheers,
Max


On 29 May 2020, at 21:38, Jakob Reschke wrote:

> Hi Max,
>
> Is there some CI system for Grease where Squeak could subscribe to the
> Squeak-specific results?
>
> Kind regards,
> Jakob
>
> Am Fr., 29. Mai 2020 um 07:54 Uhr schrieb Max Leske <[hidden email]>:
>>
>>
>>> On Thu, May 28, 2020 at 01:01:55PM -0700, tim Rowledge wrote:
>>>
>>>> Whilst checking things after installing Seaside and Cryptography I noticed that there are a couple of dangling Undeclareds that lead into some faulty loaded code.
>>>>
>>>> 'home' and 'startpc' are referenced in BlockContext>>#tempVarRefs. This is not too much of a problem since there are no senders but since there are also a bunch of methods loaded into the no longer used Context/BlockContext/MethodContext classes it might be an indicator of some updating needed in the Grease package, specifically *grease-squeak5-core. I don't know who looks after this, so if anyone does, please pass it on.
>>>>
>>
>> Thanks Tim. Ideally you would open issue reports at https://github.com/SeasideSt/Grease/issues.
>>
>> You don't mention the Squeak version you're looking at, that would help.
>>
>> We've just prepared some fixes for Squeak (e.g. #asMutator deprecation) and we could probably get those changes in to the same Release.
>>
>>>
>>>
>>> The grease package is one of those things that we, the Squeak community,
>>> need to take more responsibility for. If anyone is looking for a worthwhile
>>> Sunday Squeaker project, this would be a good one.
>>>
>>> Dave
>>
>>
>> That would be great! Just checking Grease / Seaside for obvious issues in Squeak and reporting them to us would be a huge help. We're only 3 (mostly 1) people who do most of the work and we'd love some more help.
>>
>>
>> Cheers,
>> Max



signature.asc (849 bytes) Download Attachment