Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

Tudor Girba-2
Indeed, that is a bug. Could you open a Pharo issue for this?

Cheers,
Doru

On Tue, Oct 13, 2015 at 4:51 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

I see there is a great battle involving Rubric and all its friends is taking place. 
When I browse an example, I do not have the syntax highlighting. I am using the last version of Moose.


Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev




--

"Every thing has its own flow"
Reply | Threaded
Open this post in threaded view
|

Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

Marcus Denker-4
There is this issue, too:


On 13 Oct 2015, at 17:54, Tudor Girba <[hidden email]> wrote:

Indeed, that is a bug. Could you open a Pharo issue for this?

Cheers,
Doru

On Tue, Oct 13, 2015 at 4:51 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

I see there is a great battle involving Rubric and all its friends is taking place. 
When I browse an example, I do not have the syntax highlighting. I am using the last version of Moose.

<Screen Shot 2015-10-13 at 11.49.53 AM.png>

Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev




--

"Every thing has its own flow"

Reply | Threaded
Open this post in threaded view
|

Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

abergel
In reply to this post by Tudor Girba-2
Done

-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Oct 13, 2015, at 12:54 PM, Tudor Girba <[hidden email]> wrote:

Indeed, that is a bug. Could you open a Pharo issue for this?

Cheers,
Doru

On Tue, Oct 13, 2015 at 4:51 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

I see there is a great battle involving Rubric and all its friends is taking place. 
When I browse an example, I do not have the syntax highlighting. I am using the last version of Moose.

<Screen Shot 2015-10-13 at 11.49.53 AM.png>

Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev




--

"Every thing has its own flow"

Reply | Threaded
Open this post in threaded view
|

Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

Andrei Chis
The two issue are not related. This bug appeared because the 'Playground' view was using PluggableTextMorph which no longer works on in Pharo.
I replaced the editor with rubric and it should work now.

We should deprecate the renderers based on PluggableTextMorph in glamour.
For that we need to:
   - deprecate GLMCompositePresentation>>#smalltalkCode and replace it senders with #pharoMethod and #pharoPlayground
   - switch the the rubric renderer in GLMCompositePresentation>>#text; Or do we deprecate #text and keep just #rubricText ?
   - deprecate all classes that are linked to the  PluggableTextMorph renderer.

Cheers,
Andrei




On Tue, Oct 13, 2015 at 6:35 PM, Alexandre Bergel <[hidden email]> wrote:
Done

-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Oct 13, 2015, at 12:54 PM, Tudor Girba <[hidden email]> wrote:

Indeed, that is a bug. Could you open a Pharo issue for this?

Cheers,
Doru

On Tue, Oct 13, 2015 at 4:51 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

I see there is a great battle involving Rubric and all its friends is taking place. 
When I browse an example, I do not have the syntax highlighting. I am using the last version of Moose.

<Screen Shot 2015-10-13 at 11.49.53 AM.png>

Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev




--

"Every thing has its own flow"


Reply | Threaded
Open this post in threaded view
|

Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

stepharo
Thanks Andrei :)
We were focusing on all the other users of PlugTextMorph :)

Stef

Le 13/10/15 21:48, Andrei Chis a écrit :
The two issue are not related. This bug appeared because the 'Playground' view was using PluggableTextMorph which no longer works on in Pharo.
I replaced the editor with rubric and it should work now.

We should deprecate the renderers based on PluggableTextMorph in glamour.
For that we need to:
   - deprecate GLMCompositePresentation>>#smalltalkCode and replace it senders with #pharoMethod and #pharoPlayground
   - switch the the rubric renderer in GLMCompositePresentation>>#text; Or do we deprecate #text and keep just #rubricText ?
   - deprecate all classes that are linked to the  PluggableTextMorph renderer.

Cheers,
Andrei




On Tue, Oct 13, 2015 at 6:35 PM, Alexandre Bergel <[hidden email]> wrote:
Done

-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Oct 13, 2015, at 12:54 PM, Tudor Girba <[hidden email]> wrote:

Indeed, that is a bug. Could you open a Pharo issue for this?

Cheers,
Doru

On Tue, Oct 13, 2015 at 4:51 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

I see there is a great battle involving Rubric and all its friends is taking place. 
When I browse an example, I do not have the syntax highlighting. I am using the last version of Moose.

<Screen Shot 2015-10-13 at 11.49.53 AM.png>

Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev




--

"Every thing has its own flow"



Reply | Threaded
Open this post in threaded view
|

Re: [Moose-dev] Syntax highlighting is missing in Playground and examples

Tudor Girba-2
In reply to this post by Andrei Chis
Hi,

On Tue, Oct 13, 2015 at 9:48 PM, Andrei Chis <[hidden email]> wrote:
The two issue are not related. This bug appeared because the 'Playground' view was using PluggableTextMorph which no longer works on in Pharo.
I replaced the editor with rubric and it should work now.

We should deprecate the renderers based on PluggableTextMorph in glamour.

Yes.
 
For that we need to:
   - deprecate GLMCompositePresentation>>#smalltalkCode and replace it senders with #pharoMethod and #pharoPlayground

+1
 
   - switch the the rubric renderer in GLMCompositePresentation>>#text; Or do we deprecate #text and keep just #rubricText ?

We switch text: to point to the Rubric renderer.
 
   - deprecate all classes that are linked to the  PluggableTextMorph renderer.

+1.

Doru

 
Cheers,
Andrei




On Tue, Oct 13, 2015 at 6:35 PM, Alexandre Bergel <[hidden email]> wrote:
Done

-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Oct 13, 2015, at 12:54 PM, Tudor Girba <[hidden email]> wrote:

Indeed, that is a bug. Could you open a Pharo issue for this?

Cheers,
Doru

On Tue, Oct 13, 2015 at 4:51 PM, Alexandre Bergel <[hidden email]> wrote:
Hi!

I see there is a great battle involving Rubric and all its friends is taking place. 
When I browse an example, I do not have the syntax highlighting. I am using the last version of Moose.

<Screen Shot 2015-10-13 at 11.49.53 AM.png>

Cheers,
Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




_______________________________________________
Moose-dev mailing list
[hidden email]
https://www.list.inf.unibe.ch/listinfo/moose-dev




--

"Every thing has its own flow"





--

"Every thing has its own flow"