This is interesting. I only find one sender in Swazoo of #asString that
looks like it's sent to a Number. And here's where I find it: it's in
Swazoo-Tests, and it's a helper method:
ResourceTest>>basicGetUri:host:port:
....
port notNil ifTrue: [ws nextPutAll: ':', port asString].
This could easily be removed / replaced with
port notNil
ifTrue:
[ws
nextPut: $:;
print: port].
I've made this change and removed Swazoo's (Number>>asString), and all
of the tests still run.
----
As for the eFinNet version of #asString... this would be much better
solved using the inheritance hierarchy that already exists. Why branch
on the last character of a printString when that character's very
presence depends on the class?
IOW, implement these methods:
Number>>asString
^self printString
FixedPoint>>asString
^self printString withoutLast: 1
SequenceableCollection>>withoutLast: anInteger
^self copyFrom: 1 to: self size - anInteger
There's no branching based on the last character, because you've
implemented it in the proper places. And there's no storing of the new
string in a temporary for the sake of examining its size, because you've
pushed the behavior into SequenceableCollection.
Ken Treis
[hidden email]
Locked
