Smalltalk › Squeak › Squeak VM

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 12 messages Options
Eliot Miranda-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

Eliot Miranda-2
 
Hi Tobias,

    I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.

On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
  • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
    • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22

Commit Summary

  • Prepare Cocoa VM for High-DPI

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.




--
_,,,^..^,,,_
best, Eliot
Holger Freyther
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

Holger Freyther


> On 06 Jul 2016, at 08:27, Eliot Miranda <[hidden email]> wrote:
>
> Hi Tobias,
>
>     I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>

click on the specific build that failed and i see this[1]:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated


holger

[1] https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/142601128
EstebanLM
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

EstebanLM
In reply to this post by Eliot Miranda-2
 
yeah, problem is that there is a lot of infrastructure to run :)
the error is just in one of the elements on the matrix, scrolling down the full list, is here: 


which would be: 

Setting environment variables from .travis.yml
$ export ARCH="macos32x86"
$ export FLAVOR="squeak.cog.spur"
… exactly the architecture that is intend to modify :)

Esteban


On 06 Jul 2016, at 08:27, Eliot Miranda <[hidden email]> wrote:

Hi Tobias,

    I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.

On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
  • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
    • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22

Commit Summary

  • Prepare Cocoa VM for High-DPI

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.




--
_,,,^..^,,,_
best, Eliot
Tobias Pape
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

Tobias Pape
In reply to this post by Eliot Miranda-2

Hi,


On 06.07.2016, at 08:27, Eliot Miranda <[hidden email]> wrote:

> Hi Tobias,
>
>     I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.


Incidentally, I don't see any red indications.
When I look at the link, everything is green…

Best
        -Tobias

>
> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
> • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
> • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>
> Commit Summary
>
> • Prepare Cocoa VM for High-DPI
> File Changes
>
> • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
> • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
> • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
> • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
> • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
> • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
> • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
> • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
> • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
> • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
> • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
> Patch Links:
>
> • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
> • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.



EstebanLM
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

EstebanLM

Scroll down :)
Lots of elements in the matrix, and just one is failing.

Esteban

> On 6 Jul 2016, at 09:19, Tobias Pape <[hidden email]> wrote:
>
>
> Hi,
>
>
>> On 06.07.2016, at 08:27, Eliot Miranda <[hidden email]> wrote:
>>
>> Hi Tobias,
>>
>>    I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>
>
> Incidentally, I don't see any red indications.
> When I look at the link, everything is green…
>
> Best
>    -Tobias
>
>>
>> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
>>    • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>>        • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
>> You can view, comment on, or merge this pull request online at:
>>
>>  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>>
>> Commit Summary
>>
>>    • Prepare Cocoa VM for High-DPI
>> File Changes
>>
>>    • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
>>    • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
>>    • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
>>    • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
>>    • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
>> Patch Links:
>>
>>    • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
>>    • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
>> —
>> You are receiving this because you are subscribed to this thread.
>> Reply to this email directly, view it on GitHub, or mute the thread.
>
>
>
Tobias Pape
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

Tobias Pape


On 06.07.2016, at 09:35, Esteban Lorenzano <[hidden email]> wrote:

>
> Scroll down :)
> Lots of elements in the matrix, and just one is failing.

No, all green.
http://i.imgur.com/ZsjioY7.png



>
> Esteban
>
>> On 6 Jul 2016, at 09:19, Tobias Pape <[hidden email]> wrote:
>>
>>
>> Hi,
>>
>>
>>> On 06.07.2016, at 08:27, Eliot Miranda <[hidden email]> wrote:
>>>
>>> Hi Tobias,
>>>
>>>   I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>>
>>
>> Incidentally, I don't see any red indications.
>> When I look at the link, everything is green…
>>
>> Best
>>   -Tobias
>>
>>>
>>> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
>>>   • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>>>       • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
>>> You can view, comment on, or merge this pull request online at:
>>>
>>> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>>>
>>> Commit Summary
>>>
>>>   • Prepare Cocoa VM for High-DPI
>>> File Changes
>>>
>>>   • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
>>>   • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
>>>   • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
>>>   • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
>>>   • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
>>> Patch Links:
>>>
>>>   • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
>>>   • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
>>> —
>>> You are receiving this because you are subscribed to this thread.
>>> Reply to this email directly, view it on GitHub, or mute the thread.


EstebanLM
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

EstebanLM

heh… I don’t know… now is green too :)

Esteban

> On 06 Jul 2016, at 09:41, Tobias Pape <[hidden email]> wrote:
>
>
>
> On 06.07.2016, at 09:35, Esteban Lorenzano <[hidden email]> wrote:
>
>>
>> Scroll down :)
>> Lots of elements in the matrix, and just one is failing.
>
> No, all green.
> http://i.imgur.com/ZsjioY7.png
>
>
>
>>
>> Esteban
>>
>>> On 6 Jul 2016, at 09:19, Tobias Pape <[hidden email]> wrote:
>>>
>>>
>>> Hi,
>>>
>>>
>>>> On 06.07.2016, at 08:27, Eliot Miranda <[hidden email]> wrote:
>>>>
>>>> Hi Tobias,
>>>>
>>>>  I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>>>
>>>
>>> Incidentally, I don't see any red indications.
>>> When I look at the link, everything is green…
>>>
>>> Best
>>>  -Tobias
>>>
>>>>
>>>> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
>>>>  • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>>>>      • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
>>>> You can view, comment on, or merge this pull request online at:
>>>>
>>>> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>>>>
>>>> Commit Summary
>>>>
>>>>  • Prepare Cocoa VM for High-DPI
>>>> File Changes
>>>>
>>>>  • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
>>>>  • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
>>>>  • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
>>>>  • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
>>>> Patch Links:
>>>>
>>>>  • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
>>>>  • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
>>>> —
>>>> You are receiving this because you are subscribed to this thread.
>>>> Reply to this email directly, view it on GitHub, or mute the thread.
>
>

timfelgentreff
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

timfelgentreff
 
Sorry, I should have said something - I just restarted the build and it ran just fine the second time. It was hung on something, failing the build, but that seems to have been an intermittent failure.

On 6 July 2016 at 11:55, Esteban Lorenzano <[hidden email]> wrote:

heh… I don’t know… now is green too :)

Esteban

> On 06 Jul 2016, at 09:41, Tobias Pape <[hidden email]> wrote:
>
>
>
> On <a href="tel:06.07.2016" value="+496072016">06.07.2016, at 09:35, Esteban Lorenzano <[hidden email]> wrote:
>
>>
>> Scroll down :)
>> Lots of elements in the matrix, and just one is failing.
>
> No, all green.
> http://i.imgur.com/ZsjioY7.png
>
>
>
>>
>> Esteban
>>
>>> On 6 Jul 2016, at 09:19, Tobias Pape <[hidden email]> wrote:
>>>
>>>
>>> Hi,
>>>
>>>
>>>> On <a href="tel:06.07.2016" value="+496072016">06.07.2016, at 08:27, Eliot Miranda <[hidden email]> wrote:
>>>>
>>>> Hi Tobias,
>>>>
>>>>  I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>>>
>>>
>>> Incidentally, I don't see any red indications.
>>> When I look at the link, everything is green…
>>>
>>> Best
>>>  -Tobias
>>>
>>>>
>>>> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
>>>>  • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>>>>      • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
>>>> You can view, comment on, or merge this pull request online at:
>>>>
>>>> https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>>>>
>>>> Commit Summary
>>>>
>>>>  • Prepare Cocoa VM for High-DPI
>>>> File Changes
>>>>
>>>>  • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
>>>>  • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
>>>>  • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
>>>>  • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
>>>>  • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
>>>> Patch Links:
>>>>
>>>>  • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
>>>>  • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
>>>> —
>>>> You are receiving this because you are subscribed to this thread.
>>>> Reply to this email directly, view it on GitHub, or mute the thread.
>
>
johnmci
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

johnmci
In reply to this post by Eliot Miranda-2
 
>Works for both OpenGL and CoreGraphics backends (Why do we have both?)

Originally the code was written for CoreGraphics as a port from the original QuickDraw 1984 era logic but used CALayers to improve performance. 
The open/GL logic was added as part of the development process but at the time Apple was transitioning to versions of OpenGL/ES etc so I left both in as part of the transition process. 
Today the graphics layer could look at Metal as an alternate solution. 


On Tue, Jul 5, 2016 at 11:27 PM, Eliot Miranda <[hidden email]> wrote:
 
Hi Tobias,

    I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.

On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
  • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
    • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.

You can view, comment on, or merge this pull request online at:

  https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22

Commit Summary

  • Prepare Cocoa VM for High-DPI

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.




--
_,,,^..^,,,_
best, Eliot




--
===========================================================================
John M. McIntosh. Corporate Smalltalk Consulting Ltd https://www.linkedin.com/in/smalltalk
===========================================================================
Tobias Pape
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

Tobias Pape


On 06.07.2016, at 22:18, John McIntosh <[hidden email]> wrote:

> >Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>
> Originally the code was written for CoreGraphics as a port from the original QuickDraw 1984 era logic but used CALayers to improve performance.
> The open/GL logic was added as part of the development process but at the time Apple was transitioning to versions of OpenGL/ES etc so I left both in as part of the transition process.
> Today the graphics layer could look at Metal as an alternate solution.
>

That's good to know!
I tested both ways and it turns out both work well, I have not done perf measurings, however.
The OpenGL one needs a opt-in for high-dpi, the CG one does not.
Aside from what is the default now, what would your pick be?

Best regards
        -Tobias

PS: I'll merge that now

>
> On Tue, Jul 5, 2016 at 11:27 PM, Eliot Miranda <[hidden email]> wrote:
>  
> Hi Tobias,
>
>     I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>
> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
> • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
> • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>
> Commit Summary
>
> • Prepare Cocoa VM for High-DPI
> File Changes
>
> • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
> • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
> • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
> • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
> • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
> • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
> • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
> • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
> • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
> • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
> • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
> Patch Links:
>
> • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
> • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.



johnmci
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

johnmci
 
The open/GL one has always been the default, it is faster. 

On Wed, Jul 6, 2016 at 1:27 PM, Tobias Pape <[hidden email]> wrote:


On 06.07.2016, at 22:18, John McIntosh <[hidden email]> wrote:

> >Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>
> Originally the code was written for CoreGraphics as a port from the original QuickDraw 1984 era logic but used CALayers to improve performance.
> The open/GL logic was added as part of the development process but at the time Apple was transitioning to versions of OpenGL/ES etc so I left both in as part of the transition process.
> Today the graphics layer could look at Metal as an alternate solution.
>

That's good to know!
I tested both ways and it turns out both work well, I have not done perf measurings, however.
The OpenGL one needs a opt-in for high-dpi, the CG one does not.
Aside from what is the default now, what would your pick be?

Best regards
        -Tobias

PS: I'll merge that now

>
> On Tue, Jul 5, 2016 at 11:27 PM, Eliot Miranda <[hidden email]> wrote:
>
> Hi Tobias,
>
>     I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
>
> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
>       • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
>               • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
>
> Commit Summary
>
>       • Prepare Cocoa VM for High-DPI
> File Changes
>
>       • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
>       • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
>       • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
>       • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
>       • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
> Patch Links:
>
>       • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
>       • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.






--
===========================================================================
John M. McIntosh. Corporate Smalltalk Consulting Ltd https://www.linkedin.com/in/smalltalk
===========================================================================
Tobias Pape
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

Tobias Pape


On 06.07.2016, at 22:29, John McIntosh <[hidden email]> wrote:

> The open/GL one has always been the default, it is faster.
>

Good, I'll keep that in mind.

Best regards
        -Tobias

> On Wed, Jul 6, 2016 at 1:27 PM, Tobias Pape <[hidden email]> wrote:
>
>
> On 06.07.2016, at 22:18, John McIntosh <[hidden email]> wrote:
>
> > >Works for both OpenGL and CoreGraphics backends (Why do we have both?)
> >
> > Originally the code was written for CoreGraphics as a port from the original QuickDraw 1984 era logic but used CALayers to improve performance.
> > The open/GL logic was added as part of the development process but at the time Apple was transitioning to versions of OpenGL/ES etc so I left both in as part of the transition process.
> > Today the graphics layer could look at Metal as an alternate solution.
> >
>
> That's good to know!
> I tested both ways and it turns out both work well, I have not done perf measurings, however.
> The OpenGL one needs a opt-in for high-dpi, the CG one does not.
> Aside from what is the default now, what would your pick be?
>
> Best regards
>         -Tobias
>
> PS: I'll merge that now
>
> >
> > On Tue, Jul 5, 2016 at 11:27 PM, Eliot Miranda <[hidden email]> wrote:
> >
> > Hi Tobias,
> >
> >     I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
> >
> > On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <[hidden email]> wrote:
> >       • Works for both OpenGL and CoreGraphics backends (Why do we have both?)
> >               • Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
> > You can view, comment on, or merge this pull request online at:
> >
> >   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
> >
> > Commit Summary
> >
> >       • Prepare Cocoa VM for High-DPI
> > File Changes
> >
> >       • M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
> >       • M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
> >       • M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
> >       • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
> >       • M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
> > Patch Links:
> >
> >       • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
> >       • https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.



Free forum by Nabble Edit this page