Smalltalk › Pharo › Pharo Smalltalk Users

Re: [Pharo-dev] integrating FileDialog into Pharo 7

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Pavel Krivanek-3

Re: [Pharo-dev] integrating FileDialog into Pharo 7

We should work on integration of it. Firstly please move tests to a separate package.

Cheers,

-- Pavel

2017-07-10 12:34 GMT+02:00 Peter Uhnak <[hidden email]>:

Hi,

some people expressed interest in integrating File Dialog https://github.com/peteruhnak/file-dialog into Pharo as the default file dialog.

Is it something people are interested in, or is the current solution sufficient for them?

Peter

abergel

Re: [Pharo-dev] integrating FileDialog into Pharo 7

Hi Peter!

I have been using your file dialog for some time already. I really like it. Here some ideas of improvement.
- double click instead of single click to dive in a folder? Single clicking feels a bit weird to me
- Saving on the disk for preference folders?

Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.

> On Jul 10, 2017, at 12:34 PM, Peter Uhnak <[hidden email]> wrote:
>
> Hi,
>
> some people expressed interest in integrating File Dialog https://github.com/peteruhnak/file-dialog into Pharo as the default file dialog.
>
> Is it something people are interested in, or is the current solution sufficient for them?
>
> Peter
>

Pavel Krivanek-3

Re: [Pharo-dev] integrating FileDialog into Pharo 7

In reply to this post by Pavel Krivanek-3

Can you try to prepare a pull requeast that will integrate it? The PR will need to:

- add the packages into the repository

- add them into the baseline (BaselineOfUI)

- remove old FileDialogWindow (becuase when we add something, we should remove something too ;-))

If you need help, let me know

-- Pavel

2017-07-10 20:01 GMT+02:00 Peter Uhnak <[hidden email]>:

Done. What next?

Peter

On Mon, Jul 10, 2017 at 12:46:50PM +0200, Pavel Krivanek wrote:
> We should work on integration of it. Firstly please move tests to a
> separate package.
>
> Cheers,
> -- Pavel
>
> 2017-07-10 12:34 GMT+02:00 Peter Uhnak <[hidden email]>:
>
> > Hi,
> >
> > some people expressed interest in integrating File Dialog
> > https://github.com/peteruhnak/file-dialog into Pharo as the default file
> > dialog.
> >
> > Is it something people are interested in, or is the current solution
> > sufficient for them?
> >
> > Peter
> >
> >