Smalltalk › Frameworks & Tools › GLORP

Re: [Pharo-project] GlorpDBX PostgreSQL Patch

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

Mariano Martinez Peck

Re: [Pharo-project] GlorpDBX PostgreSQL Patch

Thanks Sven. We let the repo as global read because we usually receive unintentional commits.
Do you think it is worth it to have a kind of DBXTalkInbox ?

Alan, do you think this is useful also for Glorp trunk ?

Thanks!

On Tue, Nov 8, 2011 at 5:59 AM, Sven Van Caekenberghe <[hidden email]> wrote:

Hi,

I have a patch for Glorp(DBX) PostgreSQL to support the newer bytea hex format (see file:///usr/local/pgsql/share/doc/html/datatype-binary.html#AEN5037). I can't write to the repository, so here it is:

PostgreSQLPlatform>>#convertSQLStringToByteArray: aString for: aType
aString isNil ifTrue: [ ^ nil ].
^ (aString beginsWith: '\x')
ifTrue: [ self convertHexSQLStringToByteArray: aString ]
ifFalse: [ self convertEscapeSQLStringToByteArray: aString ]

PostgreSQLPlatform>>#convertEscapeSQLStringToByteArray: aString
| aStream str |
aStream := (ByteArray new: aString size // 4) writeStream.
str := aString readStream.
[str atEnd] whileFalse: [ |nextChar|
nextChar := str next.
aStream nextPut: (nextChar = $\
ifTrue: [str peek = $\
ifTrue: [str next asInteger]
ifFalse: [Number readFrom: (str next: 3) base: 8]]
ifFalse: [nextChar asInteger])
].
aStream close.
^aStream contents

PostgreSQLPlatform>>#convertHexSQLStringToByteArray: aString
^ ByteArray
new: (aString size // 2) - 1
streamContents: [ :out | | in |
(in := aString readStream) skip: 2.
[ in atEnd ] whileFalse: [
out nextPut: (Number readFrom: (in next: 2) base: 16) ] ]

#convertEscapeSQLStringToByteArray: is the old code, unmodified; #convertHexSQLStringToByteArray: is new.
This might be of use upstream as well, I don't really know.

If it would help, I could save this as an MC package somewhere.

Regards,

Sven

--
Mariano
http://marianopeck.wordpress.com

--
You received this message because you are subscribed to the Google Groups "glorp-group" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/glorp-group?hl=en.

Alan Knight-2

Re: [Pharo-project] GlorpDBX PostgreSQL Patch

My inclination would be to think that this is something that the database driver ought to be handling rather than having it in Glorp at all. But, given that it's in there, I suppose it's not unreasonable.

[hidden email]
9 November, 2011 8:59 AM

Thanks Sven. We let the repo as global read because we usually receive unintentional commits.
Do you think it is worth it to have a kind of DBXTalkInbox ?

Alan, do you think this is useful also for Glorp trunk ?

Thanks!

--
Mariano
http://marianopeck.wordpress.com

[hidden email]
8 November, 2011 3:59 AM

Hi,

I have a patch for Glorp(DBX) PostgreSQL to support the newer bytea hex format (see file:///usr/local/pgsql/share/doc/html/datatype-binary.html#AEN5037). I can't write to the repository, so here it is:

PostgreSQLPlatform>>#convertSQLStringToByteArray: aString for: aType
aString isNil ifTrue: [ ^ nil ].
^ (aString beginsWith: '\x')
ifTrue: [ self convertHexSQLStringToByteArray: aString ]
ifFalse: [ self convertEscapeSQLStringToByteArray: aString ]

PostgreSQLPlatform>>#convertEscapeSQLStringToByteArray: aString
| aStream str |
aStream := (ByteArray new: aString size // 4) writeStream.
str := aString readStream.
[str atEnd] whileFalse: [ |nextChar|
nextChar := str next.
aStream nextPut: (nextChar = $\
ifTrue: [str peek = $\
ifTrue: [str next asInteger]
ifFalse: [Number readFrom: (str next: 3) base: 8]]
ifFalse: [nextChar asInteger])
].
aStream close.
^aStream contents

PostgreSQLPlatform>>#convertHexSQLStringToByteArray: aString
^ ByteArray
new: (aString size // 2) - 1
streamContents: [ :out | | in |
(in := aString readStream) skip: 2.
[ in atEnd ] whileFalse: [
out nextPut: (Number readFrom: (in next: 2) base: 16) ] ]

#convertEscapeSQLStringToByteArray: is the old code, unmodified; #convertHexSQLStringToByteArray: is new.
This might be of use upstream as well, I don't really know.

If it would help, I could save this as an MC package somewhere.

Regards,

Sven

Mariano Martinez Peck

Re: [Pharo-project] GlorpDBX PostgreSQL Patch

Hi guys. I am trying to understand how to integrate this in the OpenDBX driver, but I am a little bit lost.
First, I don't understand when this #byteArrayToSQLStringConverter is used. What is the bytearray and what is the string? one is the database type and the other one is the inst var of one you your mapping class?

Second, I don't know WHERE to put such conversion in the OpenDBX driver. Why it should be there if #convertSQLStringToByteArray: aString for: aType will continue to exist in Glorp. So it means I should also modify Glorp?

How does the EXDI driver of VW work here?

Thanks!

On Thu, Nov 10, 2011 at 11:15 AM, Henrik Sperre Johansen <[hidden email]> wrote:

On 10.11.2011 14:29, Sven Van Caekenberghe wrote:

Alan,

On 09 Nov 2011, at 21:20, Alan Knight wrote:

My inclination would be to think that this is something that the database driver ought to be handling rather than having it in Glorp at all. But, given that it's in there, I suppose it's not unreasonable.

Well, I just extended the previous conversion that was already located there. I did not consider whether or not that kind of platform specific code was in its right place, architecture wise.

So, will it be integrated somewhere ? If it is only integrated in the Pharo/Squeak port that is fine for me too, but it would be frustrating if it got lost on the next upstream integration.

I would just love to be able to load the standard release and have it working for me (i.e. loading blobs from a recent PostgreSQL).

Thx for the reply,

Sven

I agree with Alan, it should be in the Postgres-specific code of OpenDBX-driver.
Glorp can't be the only user who wants to read blobs, can it? ;)

Cheers,
Henry

--
Mariano
http://marianopeck.wordpress.com

Guillermo Polito

Re: [Pharo-project] GlorpDBX PostgreSQL Patch

On Fri, Nov 11, 2011 at 8:16 AM, Mariano Martinez Peck <[hidden email]> wrote:

Hi guys. I am trying to understand how to integrate this in the OpenDBX driver, but I am a little bit lost.
First, I don't understand when this #byteArrayToSQLStringConverter is used. What is the bytearray and what is the string? one is the database type and the other one is the inst var of one you your mapping class?

This is because the conversion is being done right now in glorp... We are already performing conversions in OpenDBX, but they are not platform specific conversions, since we handle only ANSI conversions ;).

Maybe we can build a PostgreSQLOpenDBXDriver (?)

Second, I don't know WHERE to put such conversion in the OpenDBX driver. Why it should be there if #convertSQLStringToByteArray: aString for: aType will continue to exist in Glorp. So it means I should also modify Glorp?

How does the EXDI driver of VW work here?

Thanks!

On Thu, Nov 10, 2011 at 11:15 AM, Henrik Sperre Johansen <[hidden email]> wrote:

On 10.11.2011 14:29, Sven Van Caekenberghe wrote:

Alan,

On 09 Nov 2011, at 21:20, Alan Knight wrote:

My inclination would be to think that this is something that the database driver ought to be handling rather than having it in Glorp at all. But, given that it's in there, I suppose it's not unreasonable.

Well, I just extended the previous conversion that was already located there. I did not consider whether or not that kind of platform specific code was in its right place, architecture wise.

So, will it be integrated somewhere ? If it is only integrated in the Pharo/Squeak port that is fine for me too, but it would be frustrating if it got lost on the next upstream integration.

I would just love to be able to load the standard release and have it working for me (i.e. loading blobs from a recent PostgreSQL).

Thx for the reply,

Sven

I agree with Alan, it should be in the Postgres-specific code of OpenDBX-driver.
Glorp can't be the only user who wants to read blobs, can it? ;)

Cheers,
Henry

--
Mariano
http://marianopeck.wordpress.com

--
You received this message because you are subscribed to the Google Groups "glorp-group" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/glorp-group?hl=en.

Alan Knight

Re: [Pharo-project] GlorpDBX PostgreSQL Patch

There are always two possible mechanisms for combining the data type with the SQL statement. We can bind it, in which case the driver is responsible for any conversion, and quite possibly it's being converted into some sort of binary representation. Or we can write it inline in the query as a string. So the VisualWorks drivers would be responsible for doing any conversion if we do binding, but it's true that we need to be responsible if we want to do it as a string.

In Postgresql, at least in VisualWorks, it's a bit confusing, because the Postgresql driver basically doesn't support binding - or at least what it does for binding is insert the literal into the string. That's more expensive, and just ends up the same, so normally I wouldn't use binding on Postgresql.

But the bottom line is that yes, we do need Glorp to be able to do this at its level, and the OpenDBX driver would only be involved if someone was using binding.

On Fri, Nov 11, 2011 at 7:33 AM, Guillermo Polito <[hidden email]> wrote:

On Fri, Nov 11, 2011 at 8:16 AM, Mariano Martinez Peck <[hidden email]> wrote:

Hi guys. I am trying to understand how to integrate this in the OpenDBX driver, but I am a little bit lost.
First, I don't understand when this #byteArrayToSQLStringConverter is used. What is the bytearray and what is the string? one is the database type and the other one is the inst var of one you your mapping class?

This is because the conversion is being done right now in glorp... We are already performing conversions in OpenDBX, but they are not platform specific conversions, since we handle only ANSI conversions ;).

Maybe we can build a PostgreSQLOpenDBXDriver (?)

Second, I don't know WHERE to put such conversion in the OpenDBX driver. Why it should be there if #convertSQLStringToByteArray: aString for: aType will continue to exist in Glorp. So it means I should also modify Glorp?

How does the EXDI driver of VW work here?

Thanks!

On Thu, Nov 10, 2011 at 11:15 AM, Henrik Sperre Johansen <[hidden email]> wrote:

On 10.11.2011 14:29, Sven Van Caekenberghe wrote:

Alan,

On 09 Nov 2011, at 21:20, Alan Knight wrote:

My inclination would be to think that this is something that the database driver ought to be handling rather than having it in Glorp at all. But, given that it's in there, I suppose it's not unreasonable.

Well, I just extended the previous conversion that was already located there. I did not consider whether or not that kind of platform specific code was in its right place, architecture wise.

So, will it be integrated somewhere ? If it is only integrated in the Pharo/Squeak port that is fine for me too, but it would be frustrating if it got lost on the next upstream integration.

I would just love to be able to load the standard release and have it working for me (i.e. loading blobs from a recent PostgreSQL).

Thx for the reply,

Sven

I agree with Alan, it should be in the Postgres-specific code of OpenDBX-driver.
Glorp can't be the only user who wants to read blobs, can it? ;)

Cheers,
Henry

--
Mariano
http://marianopeck.wordpress.com

--
You received this message because you are subscribed to the Google Groups "glorp-group" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/glorp-group?hl=en.

--
You received this message because you are subscribed to the Google Groups "glorp-group" group.
To post to this group, send email to [hidden email].
To unsubscribe from this group, send email to [hidden email].
For more options, visit this group at http://groups.google.com/group/glorp-group?hl=en.