Smalltalk › Pharo › Pharo Smalltalk Developers

Re: [Pharo-users] pharo location include korean charactor then look is not good.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

1 message

Sven Van Caekenberghe-2

Re: [Pharo-users] pharo location include korean charactor then look is not good.

I made the following quick changes:

UnixEnvironment>>#environAt: index
^ (self environ at: index) ifNotNil: [ :string | string asByteArray utf8Decoded ]

OSPlatform>>#currentWorkingDirectoryPathWithBuffer: aByteString
<primitive: 'primitiveGetCurrentWorkingDirectory' module: '' error: ec>

^ (self getPwdViaFFI: aByteString size: aByteString size)
ifNotNil: [ :string | string asByteArray utf8Decoded ]
ifNil:[ self error:'Insufficient buffer size to read current working directory: ' , aByteString size asString]

But actually almost any string coming from the VM seems wrong (i.e. should be further UTF-8 decoded):

SmalltalkImage>>#[prim]ImagePath

and #vmFileName basically probably every call VirtualMachine>>#getSystemAttribute:

what a mess ...

> On 25 May 2018, at 10:49, Sven Van Caekenberghe <[hidden email]> wrote:
>
> We looked at this before, but came to no conclusion.
>
> The problem lies with OS environment variable decoding.
>
> I created a 64-bit Pharo 7 in /tmp/été on macOS.
>
> FileLocator imageDirectory resolve.
> "File @ /private/tmp/été"
>
> Smalltalk os environment at: 'PWD'.
> "'/tmp/Ã©tÃ©'"
>
> (Smalltalk os environment at: 'PWD') asByteArray utf8Decoded.
> "'/tmp/été'"
>
> Smalltalk os environment asDictionary.
>
> FileBrowser works OK too but starts up with a wrong window title.
>
> I believe the real issue is that we are not 100% sure that it is always UTF8 on all platforms all the time (i.e. apparently users can put their (Windows) OS in a different encoding).
>
>> On 25 May 2018, at 10:28, Hilaire <[hidden email]> wrote:
>>
>> I second you on this issue. Something went wrong in the encoding in the path in your window title. Ã smells like UTF-8 issue.
>>
>> Looks like Pharo7 still has some issue(s) when handling UTF-8 characters used in modern Operating System filling system.
>>
>> Another example of this problem, with DrGeo copied in a path with UTF-8 characters, for example Été folder. When DrGeo is started, Pharo creates a folder ÃtÃ© where it creates some locale/ folder
>>
>> I see this problem on ubtuntu 17.10 and Mac OSX at my school.
>>
>> We have this problem for years, I was believing it was fixed, but apparently not.
>>
>> Hilaire
>>
>>
>> Le 25/05/2018 à 04:09, peter yoo a écrit :
>>> so.. application location include korean charactor then broken title string in pharo window.
>>> (of course ubuntu 18.04 with gnome env)
>>>
>>> broken title is "바탕화면". it's ok? or where to report?
>>>
>>> look a attached file please.
>>>
>>> --
>>
>> --
>> Dr. Geo
>> http://drgeo.eu
>>
>> <P7-utf8.png>
>