Re: Project loading broking in trunk since Squeak 5.3 release (was: Etoys help needed loading e.g. CarAndPen.014.pr)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Project loading broking in trunk since Squeak 5.3 release (was: Etoys help needed loading e.g. CarAndPen.014.pr)

Christoph Thiede
Hi Dave,

> If nobody objects in the next day or so, I will move both System-dtl.1170 and System-dtl.1171 from inbox to trunk. That will remove
the #World binding.

I would like to kindly object. :-) I share your desire to clean up outdated variables and unify access interfaces, but in this particular case IMHO the damage of probably dozens of packages not working any longer until individual patching clearly outweighs the advantages of such a cleanup ... I am afraid that many of these projects are not actively being maintained, never will be patched, and thus will be lost forever. Of course I would patch my favorite packages but I doubt that every other weekend Squeaker, likely not having subscribed to this list, will do so, too. This is why I would prefer a fallback solution with DeprecationWarning.

Best,
Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von David T. Lewis <[hidden email]>
Gesendet: Dienstag, 15. September 2020, 04:58
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] Project loading broking in trunk since Squeak 5.3 release (was: Etoys help needed loading e.g. CarAndPen.014.pr)

On Mon, Sep 14, 2020 at 07:43:47PM -0700, Eliot Miranda wrote: > Hi David, > > On Mon, Sep 14, 2020 at 5:24 PM David T. Lewis wrote: > > > I tracked this down a bit further, and the issue began after this change: > > > > Name: Collections-eem.885 > > Author: eem > > Time: 15 April 2020, 4:37:54.800631 pm > > UUID: 45d219d3-6ed0-4401-a820-44eebe21d71a > > Ancestors: Collections-eem.883, Collections-dtl.884 > > > > Switch elementsForwardIdentityTo: to not copy the hash, see > > http://forum.world.st/How-to-become-immediate-objects-td5114931.html. > > Add elementsForwardIdentityAndHashTo: for the old behavior. > > > > I made some updates to image segments to accomodate this change, and > > the Etoys project loading works again. Updates are in the inbox in > > System-dtl.1171. > > > > @eliot- This needs review because I just made naive updates that seem > > to work, but I touched several methods and I'm not sure if it got it > > right. > > > > First, sorry I broke this. Second, I looked at your changes. They look > correct to me. > Thanks Eliot. If nobody objects in the next day or so, I will move both System-dtl.1170 and System-dtl.1171 from inbox to trunk. That will remove the #World binding. I realize that there are some externally maintained projects that may be affected, but I am reassured that old Etoys projects can still be loaded, and I expect that any remaining problems can be easily addressed. Dave