Smalltalk › Frameworks & Tools › Seaside › Seaside Development

Re: [Seaside Commits] Seaside 3.0: Grease-Tests-Core-jok.41.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Julian Fitzell-2

Re: [Seaside Commits] Seaside 3.0: Grease-Tests-Core-jok.41.mcz

Oh, great! I'm glad I read all the way through because when I saw the
earlier commits I was about to ask if you would mind fixing this. :)

My only comment (and this is really more an argument I have to have
with Lukas, as he keeps moving them there) is I don't think #test*
methods should be in a 'testing' category. 'testing' is for predicate
methods, not unit tests. I've been moving them to 'tests' or 'tests-*'
gradually but it might be good to do a sweeping change if others agree
with me.

Julian

On Thu, Mar 25, 2010 at 8:19 PM,
<[hidden email]> wrote:

> John O'Keefe uploaded a new version of Grease-Tests-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Grease-Tests-Core-jok.41.mcz
>
> ==================== Summary ====================
>
> Name: Grease-Tests-Core-jok.41
> Author: jok
> Time: 25 March 2010, 4:19:03 pm
> UUID: 02128e77-76d6-7f43-a894-eabe4796310c
> Ancestors: Grease-Tests-Core-jok.40
>
> fix the broken tests
>

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Lukas Renggli

Re: [Seaside Commits] Seaside 3.0: Grease-Tests-Core-jok.41.mcz

> My only comment (and this is really more an argument I have to have
> with Lukas, as he keeps moving them there) is I don't think #test*
> methods should be in a 'testing' category. 'testing' is for predicate
> methods, not unit tests. I've been moving them to 'tests' or 'tests-*'
> gradually but it might be good to do a sweeping change if others agree
> with me.

That's fine with me. You are the british speaker :-)

Lukas

>
> Julian
>
> On Thu, Mar 25, 2010 at 8:19 PM,
> <[hidden email]> wrote:
>> John O'Keefe uploaded a new version of Grease-Tests-Core to project Seaside 3.0:
>> http://www.squeaksource.com/Seaside30/Grease-Tests-Core-jok.41.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Grease-Tests-Core-jok.41
>> Author: jok
>> Time: 25 March 2010, 4:19:03 pm
>> UUID: 02128e77-76d6-7f43-a894-eabe4796310c
>> Ancestors: Grease-Tests-Core-jok.40
>>
>> fix the broken tests
>>
> _______________________________________________
> seaside-dev mailing list
> [hidden email]
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>

--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

Lukas Renggli

Re: [Seaside Commits] Seaside 3.0: Grease-Tests-Core-jok.41.mcz

There is a script in WADevelopment that normalizes protocols. I guess
that could be extended.

Lukas

On Friday, March 26, 2010, Lukas Renggli <[hidden email]> wrote:

>> My only comment (and this is really more an argument I have to have
>> with Lukas, as he keeps moving them there) is I don't think #test*
>> methods should be in a 'testing' category. 'testing' is for predicate
>> methods, not unit tests. I've been moving them to 'tests' or 'tests-*'
>> gradually but it might be good to do a sweeping change if others agree
>> with me.
>
> That's fine with me. You are the british speaker :-)
>
> Lukas
>
>>
>> Julian
>>
>> On Thu, Mar 25, 2010 at 8:19 PM,
>> <[hidden email]> wrote:
>>> John O'Keefe uploaded a new version of Grease-Tests-Core to project Seaside 3.0:
>>> http://www.squeaksource.com/Seaside30/Grease-Tests-Core-jok.41.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: Grease-Tests-Core-jok.41
>>> Author: jok
>>> Time: 25 March 2010, 4:19:03 pm
>>> UUID: 02128e77-76d6-7f43-a894-eabe4796310c
>>> Ancestors: Grease-Tests-Core-jok.40
>>>
>>> fix the broken tests
>>>
>> _______________________________________________
>> seaside-dev mailing list
>> [hidden email]
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
>
> --
> Lukas Renggli
> http://www.lukas-renggli.ch
>

--
Lukas Renggli
http://www.lukas-renggli.ch
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

John O'Keefe-2

Re: [Seaside Commits] Seaside 3.0: Grease-Tests-Core-jok.41.mcz

In reply to this post by Julian Fitzell-2

There are still a couple broken testcases associated with this issue that I need to figure out.

John

On Thu, Mar 25, 2010 at 6:30 PM, Julian Fitzell <[hidden email]> wrote:

Oh, great! I'm glad I read all the way through because when I saw the
earlier commits I was about to ask if you would mind fixing this. :)

My only comment (and this is really more an argument I have to have
with Lukas, as he keeps moving them there) is I don't think #test*
methods should be in a 'testing' category. 'testing' is for predicate
methods, not unit tests. I've been moving them to 'tests' or 'tests-*'
gradually but it might be good to do a sweeping change if others agree
with me.

Julian

On Thu, Mar 25, 2010 at 8:19 PM,
<[hidden email]> wrote:
> John O'Keefe uploaded a new version of Grease-Tests-Core to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Grease-Tests-Core-jok.41.mcz
>
> ==================== Summary ====================
>
> Name: Grease-Tests-Core-jok.41
> Author: jok
> Time: 25 March 2010, 4:19:03 pm
> UUID: 02128e77-76d6-7f43-a894-eabe4796310c
> Ancestors: Grease-Tests-Core-jok.40
>
> fix the broken tests
>
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev

--
John O'Keefe [|], Principal Smalltalk Architect, Instantiations Inc.

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev