Re: [Seaside Commits] Seaside 3.0: Seaside-Tests-Welcome-NickAger.1.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Commits] Seaside 3.0: Seaside-Tests-Welcome-NickAger.1.mcz

Julian Fitzell-2
Yeah, this concerns me (in abstract - haven't looked at the code). I'd
be inclined to say we should add a seaside-prefixed extension method
to GRPlatform and maybe a unit test that simply makes sure the current
platform implements (as opposed to inherits) the method...

On Sun, Jul 25, 2010 at 4:25 PM,
<[hidden email]> wrote:

> Nick Ager uploaded a new version of Seaside-Tests-Welcome to project Seaside 3.0:
> http://www.squeaksource.com/Seaside30/Seaside-Tests-Welcome-NickAger.1.mcz
>
> ==================== Summary ====================
>
> Name: Seaside-Tests-Welcome-NickAger.1
> Author: NickAger
> Time: 25 July 2010, 2:25:05 pm
> UUID: 30e03d14-0800-405b-bded-77d30bd55280
> Ancestors:
>
> A difference in component creation between Pharo and Squeak caused a DNU in Squeak when trying to create a component.
> I fixed the bug, but thought that a test would be in-order - especially as there is no package for tests associated with WAWelcome.
> However I'm worried that the test is quite specific to Squeak/Pharo and also that the environment is modified; at a minimum a category 'Unclassified is created'
> The question then is - is it worthwhile having? Should it be in a platform specific set of tests?
>
>
> _______________________________________________
> commits mailing list
> To unsubscribe, email [hidden email]
> http://lists.seaside.st/listinfo/commits
>
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev