Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
Locked
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
 
|
I don't think that can be right... #url will return a full URL if
serverName, etc. are set... why not use WADispatcher>>handlerAt: combined with #defaultName to get the default dispatcher and compare for identity? I'm also a bit confused by the use of #defaultDispatcher here... don't we need to be checking the default name of whatever dispatcher we're currently viewing? Also, there's no EntryPoint class anymore so the parameter name is a bit confusing. :) Julian On Sat, Jun 12, 2010 at 8:36 PM, <[hidden email]> wrote: > Gerhard Obermann uploaded a new version of Seaside-Tools-Web to project Seaside 3.0: > http://www.squeaksource.com/Seaside30/Seaside-Tools-Web-obi.84.mcz > > ==================== Summary ==================== > > Name: Seaside-Tools-Web-obi.84 > Author: obi > Time: 12 June 2010, 7:40:06 pm > UUID: b06710cd-7b0a-4c4f-8c1e-f2243f40df05 > Ancestors: Seaside-Tools-Web-obi.83 > > - compare urls instead of strings to get the default application > > =============== Diff against Seaside-Tools-Web-obi.83 =============== > > Item was changed: > ----- Method: WAConfigurationBrowser>>renderRowName:named:on: (in category 'rendering-rows') ----- > renderRowName: anEntryPoint named: aString on: html > html anchor > class: 'selected' if: anEntryPoint = selection; > callback: [ self configure: anEntryPoint ]; > with: [ > anEntryPoint isDispatcher > ifTrue: [ html text: aString , '/' ] > ifFalse: [ > html text: aString. > + (WAUrl absolute: self defaultDispatcher defaultName) = anEntryPoint url > - self defaultDispatcher defaultName = anEntryPoint url greaseString > ifTrue: [ html span > title: 'Default application'; > with: ' (*)'] ] ]! > > > _______________________________________________ > commits mailing list > To unsubscribe, email [hidden email] > http://lists.seaside.st/listinfo/commits > seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
|
|
Fixed with Seaside-Tools-Web-obi.85.
Still not sure if the default dispatcher should be changed if I change the default application to e.g. JQuery which is not part of the root dispatcher. At the moment the default dispatcher would use "/javascript/jquery" as default name for the JQuery application. Gerhard On Sat, Jun 12, 2010 at 11:36 PM, Julian Fitzell <[hidden email]> wrote: I don't think that can be right... #url will return a full URL if _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
|
|
Oh... I don't know; that's certainly not how it was originally
intended to be used. It was intended to simply store the name of the dispatcher. If you set the root's default to 'javascript' and the javascript dispatcher's default to 'jquery', you'd have the same effect, no? Personally, I think I'd prefer having additional UI support for setting the default handler for each dispatcher in the chain if that seems like an important feature. But maybe others have another opinion? Julian On Sun, Jun 13, 2010 at 8:12 AM, Gerhard Obermann <[hidden email]> wrote: > Fixed with Seaside-Tools-Web-obi.85. > > Still not sure if the default dispatcher should be changed if I change the > default application to e.g. JQuery which is not part of the root dispatcher. > At the moment the default dispatcher would use "/javascript/jquery" as > default name for the JQuery application. > > Gerhard > > > > On Sat, Jun 12, 2010 at 11:36 PM, Julian Fitzell <[hidden email]> wrote: >> >> I don't think that can be right... #url will return a full URL if >> serverName, etc. are set... why not use WADispatcher>>handlerAt: >> combined with #defaultName to get the default dispatcher and compare >> for identity? I'm also a bit confused by the use of #defaultDispatcher >> here... don't we need to be checking the default name of whatever >> dispatcher we're currently viewing? >> >> Also, there's no EntryPoint class anymore so the parameter name is a >> bit confusing. :) >> >> Julian >> >> On Sat, Jun 12, 2010 at 8:36 PM, >> <[hidden email]> wrote: >> > Gerhard Obermann uploaded a new version of Seaside-Tools-Web to project >> > Seaside 3.0: >> > http://www.squeaksource.com/Seaside30/Seaside-Tools-Web-obi.84.mcz >> > >> > ==================== Summary ==================== >> > >> > Name: Seaside-Tools-Web-obi.84 >> > Author: obi >> > Time: 12 June 2010, 7:40:06 pm >> > UUID: b06710cd-7b0a-4c4f-8c1e-f2243f40df05 >> > Ancestors: Seaside-Tools-Web-obi.83 >> > >> > - compare urls instead of strings to get the default application >> > >> > =============== Diff against Seaside-Tools-Web-obi.83 =============== >> > >> > Item was changed: >> > ----- Method: WAConfigurationBrowser>>renderRowName:named:on: (in >> > category 'rendering-rows') ----- >> > renderRowName: anEntryPoint named: aString on: html >> > html anchor >> > class: 'selected' if: anEntryPoint = selection; >> > callback: [ self configure: anEntryPoint ]; >> > with: [ >> > anEntryPoint isDispatcher >> > ifTrue: [ html text: aString , >> > '/' ] >> > ifFalse: [ >> > html text: aString. >> > + (WAUrl absolute: self >> > defaultDispatcher defaultName) = anEntryPoint url >> > - self defaultDispatcher >> > defaultName = anEntryPoint url greaseString >> > ifTrue: [ html span >> > >> > title: 'Default application'; >> > >> > with: ' (*)'] ] ]! >> > >> > >> > _______________________________________________ >> > commits mailing list >> > To unsubscribe, email [hidden email] >> > http://lists.seaside.st/listinfo/commits >> > >> _______________________________________________ >> seaside-dev mailing list >> [hidden email] >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > > _______________________________________________ > seaside-dev mailing list > [hidden email] > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
|
Julian says:
Name: Seaside-Tools-Web-Nick.88 Author: Nick Time: 13 June 2010, 10:11:32 pm UUID: d62c23e6-967d-478a-add3-12ba15b45d1f Ancestors: Seaside-Tools-Web-Nick.87
(julian at the keyboard) Made configuration actions operate on the current dispatcher, not the default dispatcher. Remove + expand links. Cleaned up title and path generation to make sure it includes the selected handler and does not use the serverPath, etc. Added Clear Default action and Open Handler action.
On 13 June 2010 09:29, Julian Fitzell <[hidden email]> wrote: Oh... I don't know; that's certainly not how it was originally _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
|
|
If you now clear the default handler you get a simple / not found Not sure if this is a good solution? Gerhard _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
|
|
Hm... that seems "correct" to me if you don't provide a default. But
from a UI point of view, "correct" is not always what you want; so what behaviour do you suggest? (what did it do before?) Julian On Mon, Jun 14, 2010 at 8:20 PM, Gerhard Obermann <[hidden email]> wrote: > > If you now clear the default handler you get a simple > > / not found > > Not sure if this is a good solution? > > > Gerhard > > > > _______________________________________________ > seaside-dev mailing list > [hidden email] > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
|
|
Yes i know its correct from the development point of view.
I don't like it from the user interface point of view. I assume that most of the users might think its an error without some info what should be done to fix it. Don't know if older versions had the same behavior . Gerhard On Mon, Jun 14, 2010 at 10:49 PM, Julian Fitzell <[hidden email]> wrote: Hm... that seems "correct" to me if you don't provide a default. But _______________________________________________ seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
Re: [Seaside Commits] Seaside 3.0: Seaside-Tools-Web-obi.84.mcz
|
|
It has always been the case that if the default is nil you get a 404
(as far as I know). I would like to have a config option to enable or disable a listing of the contents of the dispatcher but have never got around to it. I don't know if the old UI previously did something other than set the default to nil when you cleared the handler (oh! there was no way to clear the handler, so I guess it didn't :) ). So my question is still, what do you think a better user behaviour would be? Hm... maybe it should be a 403, actually - that might be clearer? Julian On Mon, Jun 14, 2010 at 10:26 PM, Gerhard Obermann <[hidden email]> wrote: > Yes i know its correct from the development point of view. > > I don't like it from the user interface point of view. > > I assume that most of the users might think its an error > without some info what should be done to fix it. > Don't know if older versions had the same behavior . > > Gerhard > > > > On Mon, Jun 14, 2010 at 10:49 PM, Julian Fitzell <[hidden email]> wrote: >> >> Hm... that seems "correct" to me if you don't provide a default. But >> from a UI point of view, "correct" is not always what you want; so >> what behaviour do you suggest? (what did it do before?) >> >> Julian >> >> On Mon, Jun 14, 2010 at 8:20 PM, Gerhard Obermann <[hidden email]> >> wrote: >> > >> > If you now clear the default handler you get a simple >> > >> > / not found >> > >> > Not sure if this is a good solution? >> > >> > >> > Gerhard >> > >> > >> > >> > _______________________________________________ >> > seaside-dev mailing list >> > [hidden email] >> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev >> > >> > >> _______________________________________________ >> seaside-dev mailing list >> [hidden email] >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > > _______________________________________________ > seaside-dev mailing list > [hidden email] > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev > > seaside-dev mailing list [hidden email] http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev |
«
Return to Seaside Development
|
1 view|%1 views
| Free forum by Nabble | Edit this page |