Re: [Seaside Issues] Issue 686 in seaside: WAUrl uses OrderedCollection>>at:ifAbsentPut:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Issues] Issue 686 in seaside: WAUrl uses OrderedCollection>>at:ifAbsentPut:

John O'Keefe

I noticed this while porting 3.0.5 and added it to our compat layer.

John O'Keefe [|]
Principal Smalltalk Architect, Instantions Inc.

On Sep 7, 2011 12:37 AM, <[hidden email]> wrote:
> Status: Accepted
> Owner: [hidden email]
> Labels: Type-Portability Priority-High Version-Seaside3.0
>
> New issue 686 by [hidden email]: WAUrl uses
> OrderedCollection>>at:ifAbsentPut:
> http://code.google.com/p/seaside/issues/detail?id=686
>
> While porting 3.0.6 to GemStone, I came across some new code in WAUrl that
> uses #at:ifAbsentPut: on an OrderedCollection (see
> WAUrl>>privatePathParameterMapAt:)... this is new code for 3.0.6 and I
> thought that I would call attention to it.
>
> OrderedCollection>>at:ifAbsentPut: is not implemented for Dolphin or
> VisualWorks (at least the version James and I checked) so this code might
> be trouble down the road ...
>
> For GemStone, I will add OrderedCollection>>at:ifAbsentPut: to the compat
> layer, but you may want to rethink whether or not you will add Grease
> support, changed the algorithm, or????
>
> Dale
>
>
> _______________________________________________
> issues mailing list
> To unsubscribe, email [hidden email]
> http://lists.seaside.st/listinfo/issues

_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
Reply | Threaded
Open this post in threaded view
|

Re: [Seaside Issues] Issue 686 in seaside: WAUrl uses OrderedCollection>>at:ifAbsentPut:

Louis LaBrunda
Hi John,

I'm a little confused by #OrderedCollection>>at:ifAbsentPut: at least on VA
Smalltalk.  #OrderedCollection can't have gaps.  So #at:ifAbsentPut: would
only make sense for adding something to the end, like #add:.  Or is this
really not about #OrderedCollection?

Lou

>I noticed this while porting 3.0.5 and added it to our compat layer.
>
>John O'Keefe [|]
>Principal Smalltalk Architect, Instantions Inc.
>On Sep 7, 2011 12:37 AM, <[hidden email]> wrote:
>> Status: Accepted
>> Owner: [hidden email]
>> Labels: Type-Portability Priority-High Version-Seaside3.0
>>
>> New issue 686 by [hidden email]: WAUrl uses
>> OrderedCollection>>at:ifAbsentPut:
>> http://code.google.com/p/seaside/issues/detail?id=686
>>
>> While porting 3.0.6 to GemStone, I came across some new code in WAUrl that
>
>> uses #at:ifAbsentPut: on an OrderedCollection (see
>> WAUrl>>privatePathParameterMapAt:)... this is new code for 3.0.6 and I
>> thought that I would call attention to it.
>>
>> OrderedCollection>>at:ifAbsentPut: is not implemented for Dolphin or
>> VisualWorks (at least the version James and I checked) so this code might
>> be trouble down the road ...
>>
>> For GemStone, I will add OrderedCollection>>at:ifAbsentPut: to the compat
>> layer, but you may want to rethink whether or not you will add Grease
>> support, changed the algorithm, or????
>>
>> Dale
>>
>>
>> _______________________________________________
>> issues mailing list
>> To unsubscribe, email [hidden email]
>> http://lists.seaside.st/listinfo/issues
-----------------------------------------------------------
Louis LaBrunda
Keystone Software Corp.
SkypeMe callto://PhotonDemon
mailto:[hidden email] http://www.Keystone-Software.com
_______________________________________________
seaside-dev mailing list
[hidden email]
http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev