Re: The Inbox: Collections-eem.732.mcz -- HtmlReadWriter

Hi all,

On 09.02.2017, at 09:47, H. Hirzel <[hidden email]> wrote:

> On 2/8/17, Tobias Pape <[hidden email]> wrote:
>>
>> On 08.02.2017, at 19:59, Eliot Miranda <[hidden email]> wrote:
>>
>>> Hi All,
>>>
>>>    I'd really like this to be in trunk.  I've just written a blog post in
>>> a Workspace using this code
>>> (http://www.mirandabanda.org/cogblog/2017/02/07/smalltalk-scanning-and-shcontrol-structures/)
>>> and it turns creating a blog post into a simple copyHtml paste operation
>>> from a workspace to (in my case) WordPress.  So any reviewers?
>>
>> Care to explain it a litte bit? :)
>> It looks a bit complicated to my eyes.
>> Also, do you really want <pre>?
>> (http://stackoverflow.com/questions/4611591/code-vs-pre-vs-samp-for-inline-and-block-code-snippets#4611735)
>>
>> The HtmlReadWriter seems to (up until now) pretty directly map text
>> attributes to html attributes.
>>
>> You seem to want to differentiate code from non-code, so what about having a
>> do-it attribute, that does exactly that?
>> Because now, there's also no back-reading of such html into a Text object,
>> wich I find unfortunate.
>> I think, the readwriter should be able to read what it has written.
>>
>> I know, it's a mere convenience thing, but still, its very procedural, and
>> seeing #~~ in high-level code is strange to my eyes…
>>
>> What would be really cool is to
>>      - mark the code as do-it
>>      - have the do-it present itself as <code> or <pre> on Html.
> +1

So with Bert's help, I did just that (see trunk).

Workflow for Eliot could be now:
 - Write text in workspace
 - Copy (formatted) code to workspace
 - [Attention: new] select the code and CMD-6 it as DoIt
   (code is now clickable and underlined)
 - repeat until satisfied
 - yellow-click and 'copy as html'

Also, there are two test for this behavior now.

HTH

Best regards
        -Tobias

Hi all,

On 09.02.2017, at 09:47, H. Hirzel <[hidden email]> wrote:

> On 2/8/17, Tobias Pape <[hidden email]> wrote:
>>
>> On 08.02.2017, at 19:59, Eliot Miranda <[hidden email]> wrote:
>>
>>> Hi All,
>>>
>>>    I'd really like this to be in trunk.  I've just written a blog post in
>>> a Workspace using this code
>>> (http://www.mirandabanda.org/cogblog/2017/02/07/smalltalk-scanning-and-shcontrol-structures/)
>>> and it turns creating a blog post into a simple copyHtml paste operation
>>> from a workspace to (in my case) WordPress.  So any reviewers?
>>
>> Care to explain it a litte bit? :)
>> It looks a bit complicated to my eyes.
>> Also, do you really want <pre>?
>> (http://stackoverflow.com/questions/4611591/code-vs-pre-vs-samp-for-inline-and-block-code-snippets#4611735)
>>
>> The HtmlReadWriter seems to (up until now) pretty directly map text
>> attributes to html attributes.
>>
>> You seem to want to differentiate code from non-code, so what about having a
>> do-it attribute, that does exactly that?
>> Because now, there's also no back-reading of such html into a Text object,
>> wich I find unfortunate.
>> I think, the readwriter should be able to read what it has written.
>>
>> I know, it's a mere convenience thing, but still, its very procedural, and
>> seeing #~~ in high-level code is strange to my eyes…
>>
>> What would be really cool is to
>>      - mark the code as do-it
>>      - have the do-it present itself as <code> or <pre> on Html.
> +1

So with Bert's help, I did just that (see trunk).

Workflow for Eliot could be now:
 - Write text in workspace
 - Copy (formatted) code to workspace
 - [Attention: new] select the code and CMD-6 it as DoIt
   (code is now clickable and underlined)
 - repeat until satisfied
 - yellow-click and 'copy as html'

Also, there are two test for this behavior now.

HTH

Best regards
        -Tobias

Tobias,

  ignore my email.  I'm reviewing your code.  But I will say that adding inst vars is making things more complicated too.  I added three methods to achieve what I wanted and you've added 8 and an inst var ;-)

On Thu, Feb 9, 2017 at 8:16 PM, Eliot Miranda <[hidden email]> wrote:

Tobias,

  ignore my email.  I'm reviewing your code.  But I will say that adding inst vars is making things more complicated too.  I added three methods to achieve what I wanted and you've added 8 and an inst var ;-)

The problem with your indentation-based approach was that when just copying a whole method as HTML, it would insert a <pre> tag *after* the method pattern (because that was the first indented line).

That's why Tobi added the TextDoit stuff, to specifically mark code ... It's still not ideal but we couldn't come up with a better way for unifying your blog-post-in-a-workspace with the regular just-copy-some-code. Ideas welcome :)

    "Evauate aTrinaryBlock with a string and the emphasis for that string, guaranteeing
     that if the string contains a line break, it occurs at the end of the line, and the
     chanarcter following the line break if it exists."
    aText runs withStartStopAndValueDo:
        [:start :stop :attributes | | att idx startIdx |
         startIdx := start.
         [att := aText attributesAt: startIdx.
          idx := aText string indexOf: Character cr from: startIdx to: stop ifAbsent: stop.
          aTrinaryBlock
            value: (aText string copyFrom: startIdx to: idx)
            value: att
            value: (idx < stop ifTrue: [aText string at: idx + 1]).
          idx < stop]
            whileTrue:
                [startIdx := idx + 1]]

- Bert -

On Thu, Feb 9, 2017 at 8:16 PM, Eliot Miranda <[hidden email]> wrote:

Tobias,

  ignore my email.  I'm reviewing your code.  But I will say that adding inst vars is making things more complicated too.  I added three methods to achieve what I wanted and you've added 8 and an inst var ;-)

The problem with your indentation-based approach was that when just copying a whole method as HTML, it would insert a <pre> tag *after* the method pattern (because that was the first indented line). That's why Tobi added the TextDoit stuff, to specifically mark code ... It's still not ideal but we couldn't come up with a better way for unifying your blog-post-in-a-workspace with the regular just-copy-some-code. Ideas welcome :)

- Bert -

On 09.02.2017, at 21:06, Eliot Miranda <[hidden email]> wrote:

>
> OK, accepted, but if one is considering simply a text with indentation, say
>
> This is a non-indented line.
>     This is an indented line.
> This is another unindented line.
>
> We need to generate
>
>  This is a non-indented line.<br>
> <pre>    This is an indented line.
> </pre>
> This is another unindented line.<br>
>
> Right?  Right now there is no way to achieve this.  Adding a <code></code> tag pair around the indented line is wrong.  Having to mark it as a doit is wrong.  But the only way to preserve the indentation is to use <pre>.  That's what my changes (save arguably adding the closing </pre> in the wrong place) achieved.  No need to mark things as dots.  One simply indents, and whitespace is preserved.  Simple.

No, that circumvents text attributes.

I understand you want the second line indented the way you proposed, but that's not the complete truth for any text.
Because Pararaph indents, because non-code intents, because reflow (<pre> does _not_ reflow).

So the following would come out as <pre>, but that's completely unacceptable:

Voluptatem est adipisci explicabo sequi numquam sunt et quo. Possimus sunt illum culpa. Excepturi dolorum asperiores tenetur. Asperiores culpa quia dolorem eum esse et. Qui suscipit consequatur modi et. Nisi quod id hic odio.
        Reprehenderit ratione aut enim. Sed mollitia vero sed fugit iure. Quibusdam nostrum expedita dolor rerum repellat suscipit aliquam. Alias quo et nostrum est.
Qui minima hic ullam. Et iure sint sint et. Ut velit debitis qui sunt corrupti id odit asperiores.

Actually, there's a TextIndent attribute, we should make use of it (add working key code, add working html generation).

Best regards
        -Tobias

On Thu, Feb 9, 2017 at 12:11 PM, Tobias Pape <[hidden email]> wrote:

On 09.02.2017, at 21:06, Eliot Miranda <[hidden email]> wrote:

>
> OK, accepted, but if one is considering simply a text with indentation, say
>
> This is a non-indented line.
>     This is an indented line.
> This is another unindented line.
>
> We need to generate
>
>  This is a non-indented line.<br>
> <pre>    This is an indented line.
> </pre>
> This is another unindented line.<br>
>
> Right?  Right now there is no way to achieve this.  Adding a <code></code> tag pair around the indented line is wrong.  Having to mark it as a doit is wrong.  But the only way to preserve the indentation is to use <pre>.  That's what my changes (save arguably adding the closing </pre> in the wrong place) achieved.  No need to mark things as dots.  One simply indents, and whitespace is preserved.  Simple.

No, that circumvents text attributes.

I understand you want the second line indented the way you proposed, but that's not the complete truth for any text.
Because Pararaph indents, because non-code intents, because reflow (<pre> does _not_ reflow).

So the following would come out as <pre>, but that's completely unacceptable:

Voluptatem est adipisci explicabo sequi numquam sunt et quo. Possimus sunt illum culpa. Excepturi dolorum asperiores tenetur. Asperiores culpa quia dolorem eum esse et. Qui suscipit consequatur modi et. Nisi quod id hic odio.
        Reprehenderit ratione aut enim. Sed mollitia vero sed fugit iure. Quibusdam nostrum expedita dolor rerum repellat suscipit aliquam. Alias quo et nostrum est.
Qui minima hic ullam. Et iure sint sint et. Ut velit debitis qui sunt corrupti id odit asperiores.

But the current scheme loses the pargraph indent anyway.   So my way is no worse.  The current scheme throws away all indentation.  The current UI doesn't provide a way of setting paragraph indent.  So we're in a situation where if one wants to indent we can only do so by applying a <code></code> tag pair (and applying an invisible emphasis to a text).  I think this is poor.  My simple approach doesn't lose indenting, does mean that one can't use an initial paragraph indent, but does allow one, easily, and visibly, to generate correctly indented HTML.  I know what I want to chose right now.  You're forcing me to wait a long time for the right solution.  I want to generate well-formatted blog posts now.

Actually, there's a TextIndent attribute, we should make use of it (add working key code, add working html generation).

Best regards
        -Tobias

--

_,,,^..^,,,_

best, Eliot