Re: VisualGST Menu

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: VisualGST Menu

MrGwen
Hi,

I've almost finished the menu refactoring - I think
we could merge it to master ^^ -, could you made
a pass on it before merging ?

All comments, remarks are welcome ;-)

Cheers,
Gwen

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: VisualGST Menu

Paolo Bonzini-2
On Thu, Nov 4, 2010 at 10:20, Gwenaƫl Casaccio <[hidden email]> wrote:
> Hi,
>
> I've almost finished the menu refactoring - I think
> we could merge it to master ^^ -, could you made
> a pass on it before merging ?
>
> All comments, remarks are welcome ;-)

The Command part looks very nice.  The MenuBuilder subclasses are... weird.

I'd probably move at least for now the four MenuBuilder methods in
GtkMainWindow, and the subclasses as class menus in GtkVisualGSTTool.

Paolo

_______________________________________________
help-smalltalk mailing list
[hidden email]
http://lists.gnu.org/mailman/listinfo/help-smalltalk