Re: about some magritte changes I made...

Hi Esteban,

Great news!

> I made some minor changes to magritte2, to accomplish a
> few things you pointed as desirable:

Please send such mails to the list.

> 1) replace #description with #magritteDescription

Right, but that will break a lot of code. Especially with Pier, that
does a lot of fancy reflection on its structure and that is very hard
to fix (at least the last time I tried). What about doing that in a
second step?

> 2) Create a pragma-based builder, using <magritteDescription> and <magritteContainer> pragmas

Great.

- Did you consider moving the descriptions to the instance-side, so
that we have the descriptions together with the accessors and that we
can have instance- and class-side descriptions?

- Did you think about descriptions that get dynamically injected from the model?

- Did you consider getting rid of the description cache and replacing
it with a description selector cache? So that we can get the
descriptions quickly but they are built dynamically in the context of
the object?

- Did you think about the extensibility properties, i.e. with method
extensions: #descriptionFoo, #descriptionFooBarExt:,
#descriptionFooZorkExt:, ...

> 3) a small fix to make Magritte-Morphic work on Pharo 1.4 (a change on multiselect lists)

Just commit it, if it doesn't break Pharo 1.3.

> this is still not well tested (although all tests are green), but Nick wanted to start using it, so I wonder if there should be a new repository (magritte3, maybe, or "magritte2.1", whatever) to start working?
>
> what do you think, should I create it (in your repository)?

Feel free to commit it to the current repository, if it doesn't break
any builds. Otherwise we might want to submit it somewhere else before
merging into the head.

Lukas


>
> Cheers,
> Esteban



--
Lukas Renggli
www.lukas-renggli.ch
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

El 03/01/2012, a las 2:11p.m., Lukas Renggli escribió:

well... right now I just marked #description as deprecated, not that I removed it
In fact... I wasn't talk about this because I wanted to test it in a real-life environment before.

he... no, but I will start think on that now :)

>
>> 3) a small fix to make Magritte-Morphic work on Pharo 1.4 (a change on multiselect lists)
>
> Just commit it, if it doesn't break Pharo 1.3.

k, I will look... it shouldn't, but you never know :)

>
>> this is still not well tested (although all tests are green), but Nick wanted to start using it, so I wonder if there should be a new repository (magritte3, maybe, or "magritte2.1", whatever) to start working?
>>
>> what do you think, should I create it (in your repository)?
>
> Feel free to commit it to the current repository, if it doesn't break
> any builds. Otherwise we might want to submit it somewhere else before
> merging into the head.

ok, I will, after I review some small issues.

Esteban



_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

On 03/01/12 12:17 PM, Esteban Lorenzano wrote:
>> Feel free to commit it to the current repository, if it doesn't break
>> any builds. Otherwise we might want to submit it somewhere else before
>> merging into the head.
>
> ok, I will, after I review some small issues.

Does this mean you intend to commit it to the Magritte2 repository?

I do not build directly from the Magritte2 repository. I use local
copies of whatever was the latest, whenever I choose to sync up. So it
would be a long time before I see these changes in my build (unless I
fork something off to test your changes). I would not want to track a
work-in-progress with my regular build, because there would be too many
variables (i.e. did I break something, or did something change in Magritte).

IMHO, changing Magritte descriptions would warrant using some staging,
instead of going directly to head. On the other hand, things often don't
get used & tested until they appear in the head. Don't know what the
right answer is, except that posting to this list about the changes is
important.

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

ok, as I't might cause some problems because of deprecation of #description (also, it will be even harder after moving descriptions to client side), I prefer to work on an alternative repository in the mean time...
Problem now is that I can't create a repository for this (just admin has rights). I was trying to create something like "Magritte2Unstable"... Lukas could you create a repository for this?

Thanks,
Esteban

El 04/01/2012, a las 2:41p.m., Yanni Chiu escribió:


_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

I've created http://source.lukas-renggli.ch/magritte2unstable.

If you want I can also setup a continuous build?

Lukas

On 4 January 2012 20:38, Esteban Lorenzano <[hidden email]> wrote:


--
Lukas Renggli
www.lukas-renggli.ch

_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Hi,

well, I want to announce the born of magritte2unstable project, where I will place some changes to magritte:

- a pragma builder, <magritte> and <magritteContainer>
- #magritteDescription instead #description

also, I will follow Lukas recommendations to enhance the framework.

for now, there are just packages I'm changing, plus a ConfigurationOfMagritte2 who looks first in unstable repository.

current development version is '2.1'

there are 3 failures and 1 error in tests, related to a powerful capability I didn't even know it was there until I wrote the pragma builder: description extensions... I don't know how to tackle that with pragmas...

best,
Esteban
_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

While you're changing things, what do you think about:
1) change #asMorph to something like forMorphic (returns a presenter, not a Morph)
2) MAContainerMorph and friends -> MAMorphicContainer - these are not Morphs. I was actually astonished when I saw they did not inherit from Morph.

Sean

Esteban,

this is really great. A long awaited task you are tackling now. Do you plan to enable instance side descriptions as well?

Norbert

Am 05.01.2012 um 00:05 schrieb Esteban Lorenzano:


_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki

Hi,

it is planned... as far as I saw, is more or less trivial but I wanted to have 100% green tests before start next stage.
If you want to try the change by yourself, please, go ahead :)


El 05/01/2012, a las 8:41a.m., Norbert Hartl escribió:


_______________________________________________
Magritte, Pier and Related Tools ...
https://www.iam.unibe.ch/mailman/listinfo/smallwiki