Re: [bug] gst-remote and snapshots

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [bug] gst-remote and snapshots

MrGwen
Issue status update for
http://smalltalk.gnu.org/project/issue/496
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/496

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  nico
 Updated by:   MrGwen
 Status:       active
 Attachment:   http://smalltalk.gnu.org/files/issues/Remote.patch (2.08 KB)

This patch should solve the problem.



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] gst-remote and snapshots

Paolo Bonzini-3
Issue status update for
http://smalltalk.gnu.org/project/issue/496
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/496

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  nico
 Updated by:   bonzinip
 Status:       active

(01:33:35 PM) bonzini: MrGwen: can you change it to check
#aboutToSnapshot and
    resume on #finishedSnapshot instead?
(01:33:54 PM) MrGwen: I'll try
(01:34:36 PM) bonzini: MrGwen: also, perhaps change it to instance side
and use
    r := Remote new.
(01:34:46 PM) bonzini: MrGwen: this way on #returnFromSnapshot you can
do
    #removeDependent:
(01:35:19 PM) bonzini: MrGwen: long term we can move more parts of the
script into
    the new class
(01:35:24 PM) bonzini: MrGwen: very good anyway, thanks!



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] gst-remote and snapshots

MrGwen
Issue status update for
http://smalltalk.gnu.org/project/issue/496
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/496

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  nico
 Updated by:   MrGwen
 Status:       active
 Attachment:   http://smalltalk.gnu.org/files/issues/Remote2.patch (2.43 KB)

I've made the following changes:
 - everything is instance side
 - in update : if #aboutToSnapshot then suspend the process, else if
#finishedSnapshot resume it and finally if it's #returnFromSnapshot
removeDependent.

I've tested it and seems ok

Gwen



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk
Reply | Threaded
Open this post in threaded view
|

Re: [bug] gst-remote and snapshots

Paolo Bonzini-3
Issue status update for
http://smalltalk.gnu.org/project/issue/496
Post a follow up:
http://smalltalk.gnu.org/project/comments/add/496

 Project:      GNU Smalltalk
 Version:      <none>
 Component:    Base classes
 Category:     bug reports
 Priority:     normal
 Assigned to:  Unassigned
 Reported by:  nico
 Updated by:   bonzinip
-Status:       active
+Status:       fixed

I'll rename the object to RemoteServer and apply the patch.



_______________________________________________
help-smalltalk mailing list
[hidden email]
https://lists.gnu.org/mailman/listinfo/help-smalltalk