Smalltalk › Frameworks & Tools › eToys Development

Re: [etoys-notify] [JIRA] Commented: (SQ-1049) ScriptEditorMorph embeds in Holder/Playfields/Flaps

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

K K Subbu

Re: [etoys-notify] [JIRA] Commented: (SQ-1049) ScriptEditorMorph embeds in Holder/Playfields/Flaps

On Monday 19 Mar 2012 9:55:52 AM Stephen Thomas (JIRA) wrote:
> Okay this is embarrassing. After just giving this a +1 I am now changing
> to -1. Right after I made this comment (thinking about all the problems I
> have had when a script embeds into a playfield when I didn't want it to, I
> just created a project where I embedded scripts in a flap, which I find
> most useful. So I really think this needs more thought and may be
> effected by the results of SQ-1013.
I think this is because there is a difference between tools (like editor,
painter, inspector,..) and other morphs when it comes to handling drop events.
Tools get dropped or picked up implicitly in a drag or drop operation only in
a world or flap and not on their submorphs. For instance, dropping a inspector
tool in a playfield does not necessarily imply an embed op.

We could add a isTool method to Morph (false) and override it in tool Morphs
(true) to decide if the drop target should be a submorph, a flap or a world.

Regards .. Subbu
_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev

Karl Ramberg

Re: [etoys-notify] [JIRA] Commented: (SQ-1049) ScriptEditorMorph embeds in Holder/Playfields/Flaps

On Mon, Mar 19, 2012 at 6:52 AM, K. K. Subramaniam <[hidden email]> wrote:

On Monday 19 Mar 2012 9:55:52 AM Stephen Thomas (JIRA) wrote:
> Okay this is embarrassing. After just giving this a +1 I am now changing
> to -1. Right after I made this comment (thinking about all the problems I
> have had when a script embeds into a playfield when I didn't want it to, I
> just created a project where I embedded scripts in a flap, which I find
> most useful. So I really think this needs more thought and may be
> effected by the results of SQ-1013.
I think this is because there is a difference between tools (like editor,
painter, inspector,..) and other morphs when it comes to handling drop events.
Tools get dropped or picked up implicitly in a drag or drop operation only in
a world or flap and not on their submorphs. For instance, dropping a inspector
tool in a playfield does not necessarily imply an embed op.

We could add a isTool method to Morph (false) and override it in tool Morphs
(true) to decide if the drop target should be a submorph, a flap or a world.

We can just reuse the option from SystemWindows to guard against automatic embedding.

I also think tools have a special use and meaning. You use tools to create the environment not to a part of it.

Lame example: if you build a chair, the tools you use should not be glued to it by default.

Karl

_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev