Re: [etoys-notify] [JIRA] Created: (SQ-1119) Rotating flaps DNU and other mishaps

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [etoys-notify] [JIRA] Created: (SQ-1119) Rotating flaps DNU and other mishaps

dcorking
On Oct 9, Karl Ramberg (JIRA) <[hidden email]> wrote:
>                  Key: SQ-1119
>                  URL: http://tracker.squeakland.org/browse/SQ-1119
...
> Most flaps can be rotated by rotation handle but none of them do this gracefully. Viewer flaps give DNU when collapsed and opened again. 'About' flap leaves a green transformation morph on the desktop.
>
> Should we disable  the rotation handle for flaps ?
> I can't really see a use case for rotating a flap, except for a cool factor ;-)

A field report of this bug on the Squeakland list drew my attention.(*)

This seems to be a regression. The same bug occurs in Squeak Trunk,
but not in Squeak 3.0 (12 years old) where you can happily, though pointlessly,
rotate flaps.

However, the workaround of removing the rotation handle seems fine for
now. (This is done for SugarNavigatorBar in 5.0.1, but not for other flaps.)

Note that if a user tries to rotate a flap from its viewer or a
script, the DNU will also happen, so a deeper workaround should be to
disable all the rotation vocabulary from flap scripting.

It would be nice if we could track down the regression at some point:
not for the cool factor, but just for cleaner code :)

I can see that fullBounds is not being set for the
TransformationMorph, but I can't see why not, so I'll leave that to
those with more experience, if you don't mind.

Have fun! David

* http://forum.world.st/Is-this-a-possible-runtime-bug-td4666692.html
or http://lists.squeakland.org/pipermail/squeakland/2013-January/006606.html
_______________________________________________
etoys-dev mailing list
[hidden email]
http://lists.squeakland.org/mailman/listinfo/etoys-dev